Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify BorderRadius::resolve #18595

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Constify BorderRadius::resolve #18595

wants to merge 2 commits into from
+16 −15

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Mar 28, 2025 •
edited
Loading

Objective

Constify BorderRadius::resolve

Solution

  • Make BorderRadius::resolve and BorderRadius::resolve_single_corner const.
  • Swap the order of the bottom_left and bottom_right fields of BorderRadius and ResolvedBorderRadius so they match the ccw order used in the shader and in css.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greeble-dev greeble-dev greeble-dev approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ickshonpe @greeble-dev