Fix NonMesh draw command item queries #17893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd sort by key like other phase items Unbreaks draw command item queries
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
IceSentry
approved these changes
Mar 9, 2025
kristoff3r
approved these changes
Mar 25, 2025
IceSentry
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Mar 30, 2025
# Objective This fixes `NonMesh` draw commands not receiving render-world entities since - #17698 This unbreaks item queries for queued non-mesh entities: ```rust struct MyDrawCommand { type ItemQuery = Read<DynamicUniformIndex<SomeUniform>>; // ... } ``` ### Solution Pass render entity to `NonMesh` draw commands instead of `Entity::PLACEHOLDER`. This PR also introduces sorting of the `NonMesh` bin keys like other types, which I assume is the intended behavior. @pcwalton ## Testing - Tested on a local project that extensively uses `NonMesh` items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This fixes
NonMeshdraw commands not receiving render-world entities sinceThis unbreaks item queries for queued non-mesh entities:
Solution
Pass render entity to
NonMeshdraw commands instead ofEntity::PLACEHOLDER. This PR also introduces sorting of theNonMeshbin keys like other types, which I assume is the intended behavior. @pcwaltonTesting
NonMeshitems.