Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic fallible_systems example #17813

Merged

Conversation

mockersf
Copy link
Member

Objective

  • fallible_systems example is not deterministic

Solution

  • Make it deterministic
  • Also fix required feature declaration

@mockersf mockersf added the C-Examples An addition or correction to our examples label Feb 11, 2025
@@ -2159,13 +2159,13 @@ wasm = false
name = "fallible_systems"
path = "examples/ecs/fallible_systems.rs"
doc-scrape-examples = true
required-features = ["bevy_mesh_picking_backend"]
Copy link
Contributor

@rparrett rparrett Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Example seems to work if I remove it and I see bevy_mesh_picking_backend in default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strictly speaking, no, it's a default feature

@rparrett
Copy link
Contributor

Is the point of the sampled points just to add some more ?able methods to setup?

I find it sort of confusing that they are pickable. I went down a tiny rabbit hole trying to figure out why the points sometimes separated from the sphere.

@JeanMertz
Copy link
Contributor

I find it sort of confusing that they are pickable. I went down a tiny rabbit hole trying to figure out why the points sometimes separated from the sphere.

I agree, that is unfortunate. I wanted to have some way to trigger an observer that – under certain conditions – results in an error. This was a way I could think of doing that, but I'm open to changing it to something that better illustrates the point we're trying to make.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 11, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Testing A change that impacts how we test Bevy or how users test their apps labels Feb 11, 2025
Merged via the queue into bevyengine:main with commit cff1736 Feb 12, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants