-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in scene example #17799
Fix error in scene example #17799
Conversation
hash: 17588334858059901562, | ||
name: "joe", | ||
), | ||
"bevy_ecs::name::Name": "name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use a name that is not "name", just to avoid confusion? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, nice catch!
option 2 for me! |
Objective
After #16894, this example started logging errors:
Fixes #17798, this is the only actionable/unreported issue in there as far as I can tell.
Solution
Update the serialized scene with the expected format for
Name
Testing
cargo run --example scene
Discussion
This example breaks very often and we don't always catch it. It might be nice to have this scene either
Either of those would make the failures visible in the example report. Not sure which method would best suit the example.