Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to the types on the documentation of GltfAssetLabel #17791

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Add links to the types on the documentation of GltfAssetLabel #17791

merged 1 commit into from
Feb 11, 2025

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented Feb 11, 2025

Objective

Allow quick jump to definition of types of GlTFs labeled assets.

Solution

Add links to the types refered on the docs of GltfAssetLabel

Testing

Ran cargo run -p ci

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 11, 2025
@alice-i-cecile alice-i-cecile added the A-glTF Related to the glTF 3D scene/model format label Feb 11, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 11, 2025
Merged via the queue into bevyengine:main with commit 5e9da92 Feb 11, 2025
35 checks passed
@hukasu hukasu deleted the add-docs-links-to-gltf-asset-label branch February 11, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-glTF Related to the glTF 3D scene/model format C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hukasu @alice-i-cecile