Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run example in CI on windows using static dxc #17783

Merged
merged 1 commit into from
Feb 10, 2025
Merged

run example in CI on windows using static dxc #17783

merged 1 commit into from
Feb 10, 2025

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 10, 2025 •
edited
Loading

Objective

  • Run more things on windows

Solution

  • With the update of wgpu and the statically linked dxc, examples now run on windows in CI

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Feb 10, 2025
@alice-i-cecile alice-i-cecile added the O-Windows Specific to the Windows desktop operating system label Feb 10, 2025
alice-i-cecile
alice-i-cecile approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go~!

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 10, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 10, 2025
Merged via the queue into bevyengine:main with commit 7d14182 Feb 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior O-Windows Specific to the Windows desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @IceSentry