Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated generate_view_layouts in favor of layout_entries (#17537) #17714

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

deprecated generate_view_layouts in favor of layout_entries (#17537) #17714

wants to merge 3 commits into from
+2 −1

Conversation

Utope
Copy link

@Utope Utope commented Feb 7, 2025

Objective

deprecated generate_view_layouts in favor of layout_entries as described in #17537

@ickshonpe ickshonpe added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Code-Quality A section of code that is hard to understand or change labels Feb 8, 2025
fjkorf
fjkorf approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@fjkorf fjkorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through the Issue and the code changes. I have a minor string gripe but otherwise this looks good.

crates/bevy_pbr/src/render/mesh_view_bindings.rs Outdated
@@ -470,6 +470,7 @@ impl MeshPipelineViewLayouts {

/// Generates all possible view layouts for the mesh pipeline, based on all combinations of
/// [`MeshPipelineViewLayoutKey`] flags.
#[deprecated(since = "0.16.0", note = "Use layout_entries instead")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticks on layout_entries

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like me to change this real quick?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good

@IceSentry
Copy link
Contributor

Did someone investigate in which commit generate_view_layout stopped being used? I'm a bit surprised it's dead right now.

@Utope
Copy link
Author

Utope commented Mar 8, 2025 •
edited
Loading

The issue had 'Ready-For-Implemenation-Tag' so I assumed someone had checked it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjkorf fjkorf fjkorf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Utope @IceSentry @fjkorf @ickshonpe