-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Extract sprites into a Vec
#17619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 10 commits into
bevyengine:main
from
ickshonpe:extract-sprites-to-vec
Mar 18, 2025
Merged
Extract sprites into a Vec
#17619
alice-i-cecile
merged 10 commits into
bevyengine:main
from
ickshonpe:extract-sprites-to-vec
Mar 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/bevy into extract-sprites-to-vec
Carter0
approved these changes
Jan 31, 2025
alice-i-cecile
approved these changes
Feb 25, 2025
@ickshonpe if you can get CI passing I'll merge this in for you :) |
@alice-i-cecile CI is passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Performance
A change motivated by improving speed, memory usage or compile times
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Extract sprites into a
Vec
instead of aHashMap
.Solution
Extract UI nodes into a
Vec
instead of anEntityHashMap
.Add an index into the
Vec
toTransparent2d
.Compare both the index and render entity in prepare so there aren't any collisions.
Showcase
yellow this PR, red main
extract_sprites
queue_sprites