Fix cursor hotspot out of bounds when flipping #17571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenjaminBrienen fancy reviewing this if you get a chance? |
ecoskey
added
C-Bug
alice-i-cecile
approved these changes
Feb 2, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - Fix off by one error introduced in bevyengine#17540 causing: ``` Cursor image StrongHandle<Image>{ id: Index(AssetIndex { generation: 0, index: 3 }), path: Some(cursors/kenney_crosshairPack/Tilesheet/crosshairs_tilesheet_white.png) } is invalid: The specified hotspot (64, 64) is outside the image bounds (64x64). ``` - First PR commit and run shows the bug: https://github.com/bevyengine/bevy/actions/runs/13009405866/job/36283507530?pr=17571 - Second PR commit fixes it. ## Solution - Hotspot coordinates are 0-indexed, so we need to subtract 1 from the width and height. ## Testing - Fix the tests which included the off-by-one error in their expected values. - Consolidate the tests into a single test for brevity. - Test round trip transform to ensure we can "undo" to get back to the original value. - Add a specific bounds test. - Ran the example again and observed there are no more error logs: `cargo run --example custom_cursor_image --features=custom_cursor`.
joshua-holmes
pushed a commit
to joshua-holmes/bevy
that referenced
this pull request
Feb 5, 2025
# Objective - Fix off by one error introduced in bevyengine#17540 causing: ``` Cursor image StrongHandle<Image>{ id: Index(AssetIndex { generation: 0, index: 3 }), path: Some(cursors/kenney_crosshairPack/Tilesheet/crosshairs_tilesheet_white.png) } is invalid: The specified hotspot (64, 64) is outside the image bounds (64x64). ``` - First PR commit and run shows the bug: https://github.com/bevyengine/bevy/actions/runs/13009405866/job/36283507530?pr=17571 - Second PR commit fixes it. ## Solution - Hotspot coordinates are 0-indexed, so we need to subtract 1 from the width and height. ## Testing - Fix the tests which included the off-by-one error in their expected values. - Consolidate the tests into a single test for brevity. - Test round trip transform to ensure we can "undo" to get back to the original value. - Add a specific bounds test. - Ran the example again and observed there are no more error logs: `cargo run --example custom_cursor_image --features=custom_cursor`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
cargo run --example custom_cursor_image --features=custom_cursor.