Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronized component registration #17569

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
54d411d
outlined structure
ElliottjPierce Jan 26, 2025
8112810
removed storages from registration
ElliottjPierce Jan 27, 2025
6761337
re-archetected synchronization
ElliottjPierce Jan 27, 2025
41b243c
sorted out registering
ElliottjPierce Jan 27, 2025
98ba5c3
consolidated components together
ElliottjPierce Jan 27, 2025
d5232d1
gets component info
ElliottjPierce Jan 27, 2025
0bd939e
some mutable gets
ElliottjPierce Jan 27, 2025
d009642
repaired some signatures
ElliottjPierce Jan 27, 2025
49ee1dc
component interface MVP
ElliottjPierce Jan 27, 2025
0c04a57
cleaned up most usages
ElliottjPierce Jan 27, 2025
788b61d
components are cleaned
ElliottjPierce Jan 27, 2025
9cc0537
cleaned up implementation
ElliottjPierce Jan 27, 2025
578491a
re-aranged for convinience
ElliottjPierce Jan 27, 2025
139eedb
re-organized to use previous implementations where possible
ElliottjPierce Jan 27, 2025
4d9fb2b
use trait interface
ElliottjPierce Jan 27, 2025
070e629
fixed most errors
ElliottjPierce Jan 27, 2025
bc8cbbb
redid required components read interface
ElliottjPierce Jan 27, 2025
0fb4071
replace instead of merge.
ElliottjPierce Jan 28, 2025
e3c8833
inlined some functions
ElliottjPierce Jan 28, 2025
e37011f
final utils
ElliottjPierce Jan 28, 2025
58f7443
reserve space before spawning
ElliottjPierce Jan 29, 2025
9f8fe6f
no panics on missing set
ElliottjPierce Jan 29, 2025
ac6ce01
fixed docs
ElliottjPierce Jan 29, 2025
b6845bd
keep a changed flag.
ElliottjPierce Jan 29, 2025
3dd2b32
fixed no_std
ElliottjPierce Jan 29, 2025
4f86c9b
fixed more docs
ElliottjPierce Jan 29, 2025
f7e07e4
add mut and ref for components
ElliottjPierce Jan 29, 2025
22ea546
split the trait into ref and mut variants
ElliottjPierce Jan 29, 2025
12a9a5d
separated ComponentsView again for refs
ElliottjPierce Jan 29, 2025
924ae2b
implemented these traits for Components
ElliottjPierce Jan 29, 2025
e46d267
cleaned up imports
ElliottjPierce Jan 29, 2025
2693a23
fixed final error
ElliottjPierce Jan 29, 2025
55c918a
forward common synced methods through world
ElliottjPierce Jan 29, 2025
69e68b1
fixed docs
ElliottjPierce Jan 29, 2025
95713a6
Merge branch 'main' into synchronized-component-registration
ElliottjPierce Jan 29, 2025
3303567
added basic benchmarks
ElliottjPierce Jan 29, 2025
dcbecd3
amended benchmarks
ElliottjPierce Jan 29, 2025
5383023
added read locks
ElliottjPierce Jan 29, 2025
99d020e
ComponentsVew can see required components
ElliottjPierce Jan 29, 2025
e359432
removed old required components ref
ElliottjPierce Jan 29, 2025
6bf934e
don't clone required by when staging changes
ElliottjPierce Jan 29, 2025
ca03214
don't clone required components for staging
ElliottjPierce Jan 29, 2025
c8bed70
bit of polish
ElliottjPierce Jan 29, 2025
00ed24c
Merge branch 'main' into synchronized-component-registration
ElliottjPierce Jan 29, 2025
aa1af43
fixed docs
ElliottjPierce Jan 29, 2025
7934879
quick rename
ElliottjPierce Jan 29, 2025
4242865
renamed is_new to is_staged
ElliottjPierce Jan 30, 2025
fe58464
Merge branch 'main' into synchronized-component-registration
ElliottjPierce Jan 30, 2025
c57a570
Merge branch 'main' into synchronized-component-registration
ElliottjPierce Feb 2, 2025
3993bc5
Apply suggestions from code review
ElliottjPierce Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into synchronized-component-registration
  • Loading branch information
ElliottjPierce authored Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 95713a6dab9a3755385b1eeb41ed0c5144172cff

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.