Let init_non_send_resource require FromWorld instead of Default #13779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If possible, I would like this to get into 0.14 in order to not break that API unnecessarily. |
NiklasEi
added
P-Regression
alice-i-cecile
approved these changes
Jun 9, 2024
alice-i-cecile
added
C-Bug
SkiFire13
approved these changes
Jun 9, 2024
Member
Author
|
I didn't even manage to write on Discord before Alice had labeled and approved :D |
mockersf
approved these changes
Jun 9, 2024
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
do you want to add a test to avoid another future regression?
NiklasEi
commented
Jun 10, 2024
mockersf
pushed a commit
that referenced
this pull request
Jun 10, 2024
# Objective - Let `init_non_send_resource` take `FromWorld` values again, not only `Default` - This reverts an unintended breaking change introduced in #9202 ## Solution - The resource initialized with `init_non_send_resource` requires `FromWorld` again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
init_non_send_resourcetakeFromWorldvalues again, not onlyDefaultAppandSubAppinternals for better separation #9202Solution
init_non_send_resourcerequiresFromWorldagain