Skip to content

Conversation

@maniwani
Copy link
Contributor

Objective

I goofed. #7611 forgot to change the default update modes set by the WinitPlugin.

impl Default for WinitSettings {
fn default() -> Self {
WinitSettings {
focused_mode: UpdateMode::Continuous,
unfocused_mode: UpdateMode::Continuous,
}
}
}

.init_resource::<WinitSettings>()

Solution

Change Default impl for WinitSettings to return the game settings that limit FPS when the app runs in the background.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 11, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 11, 2024
@mockersf mockersf removed this pull request from the merge queue due to a manual request Jan 11, 2024
@mockersf
Copy link
Member

mockersf commented Jan 11, 2024

I would really prefer if we fix issues #11273 and #11274 before merging this as this would create a lot of issues for CI (https://github.com/bevyengine/bevy/actions/runs/7493996227/job/20400936658 would have timed out)

@mockersf mockersf added S-Blocked This cannot move forward until something else changes and removed S-Blocked This cannot move forward until something else changes labels Jan 11, 2024
@mockersf mockersf added this pull request to the merge queue Jan 15, 2024
Merged via the queue into bevyengine:main with commit aeab690 Jan 15, 2024
@maniwani maniwani deleted the background-rate-limiting-for-real-this-time branch June 20, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants