Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up no_std CI check #17506

Closed
BenjaminBrienen opened this issue Jan 23, 2025 · 0 comments · Fixed by #18333
Closed

Clean up no_std CI check #17506

BenjaminBrienen opened this issue Jan 23, 2025 · 0 comments · Fixed by #18333
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Embedded Weird hardware and no_std platforms S-Blocked This cannot move forward until something else changes

Comments

@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented Jan 23, 2025 •
edited
Loading

...I'll work on threading the feature gates through bevy_internal and into bevy. At that point that whole CI task could be replaced with a single cargo check --no-default-features --features ... --target ... instead. And then an example too!

Originally posted by @bushrat011899 in #17505 (comment)

Contributes to #15460
@BenjaminBrienen BenjaminBrienen added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Blocked This cannot move forward until something else changes labels Jan 23, 2025
@BenjaminBrienen BenjaminBrienen added this to the 0.16 milestone Jan 23, 2025
@alice-i-cecile alice-i-cecile added the O-Embedded Weird hardware and no_std platforms label Jan 23, 2025
@alice-i-cecile alice-i-cecile removed this from the 0.16 milestone Feb 24, 2025
@bushrat011899 bushrat011899 mentioned this issue Mar 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2025
@bushrat011899 @greeble-dev
Add no_std Library Example (#18333)
958c9bb 
# Objective

- Fixes #17506
- Fixes #16258

## Solution

- Added a new folder of examples, `no_std`, similar to the `mobile`
folder.
- Added a single example, `no_std_library`, which demonstrates how to
make a `no_std` compatible Bevy library.
- Added a new CI task, `check-compiles-no-std-examples`, which checks
that `no_std` examples compile on `no_std` targets.
- Added `bevy_platform_support::prelude` to `bevy::prelude`.

## Testing

- CI

---

## Notes

- I've structured the folders here to permit further `no_std` examples
(e.g., GameBoy Games, ESP32 firmware, etc.), but I am starting with the
simplest and least controversial example.
- I've tried to be as clear as possible with the documentation for this
example, catering to an audience who may not have even heard of `no_std`
before.

---------

Co-authored-by: Greeble <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Embedded Weird hardware and no_std platforms S-Blocked This cannot move forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add no_std Library Example bushrat011899/bevy
2 participants
@alice-i-cecile @BenjaminBrienen