-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add setHeader functionality for httpRoutes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Plotnikov <[email protected]>
Closed
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Signed-off-by: Philipp Plotnikov <[email protected]>
Closed
kostis-codefresh
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of ArgoRollouts
Plugin will take "http-route" of HttpRoute type and will add rules corresponding setHeaderRoute step. One step - one rule. Also it will add Path and QueryParams match from first HTTPRoute rule where stable and canary service is. GatewayAPI will use rule where more matches fit. Plugin will delete header rules when it will get event removeManagedRoutes or on the step like in the example (remove header route)
After setHeaderRoute step
Plugin save where(which index) and what headerRoute step in configMap. Plugin creates if configMap wasn't created with specified name under key configMap and in specified namespace under key namespace like here
If you dont specify the configMap, its default name will be argo-gatewayapi-configmap