-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetHeader option support #21
Comments
I am also interested in this. Thanks! |
Hi, thank you for idea. I think it will be nice feature for the plugin. I think we can implement it and I have suggestion how we can do it.
I tested it locally. It works. What do you think ? |
The structure of Argo Rollouts manifest will be the following apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
name: rollouts-demo
spec:
replicas: 5
revisionHistoryLimit: 2
selector:
matchLabels:
app: rollouts-demo
template:
metadata:
labels:
app: rollouts-demo
spec:
containers:
- name: rollouts-demo
image: argoproj/rollouts-demo:green
ports:
- name: http
containerPort: 8080
protocol: TCP
strategy:
canary:
stableService: stable-service
canaryService: canary-service
trafficRouting:
managedRoutes:
- name: header-route
plugins:
argoproj-labs/gatewayAPI:
namespace: default
httpRoute: http-route
steps:
- setWeight: 20
- setHeaderRoute: # enable header based traffic routing where
name: "header-route"
match:
- headerName: Custom-Header1 # Custom-Header1=Mozilla
headerValue:
exact: Mozilla
- headerName: Custom-Header2 # or Custom-Header2 has a prefix Mozilla
headerValue:
prefix: Mozilla
- headerName: Custom-Header3 # or Custom-Header3 value match regex: Mozilla(.*)
headerValue:
regex: Mozilla(.*)
- pause: {}
- setHeaderRoute:
name: "header-route" If match header type in argo manifest is exact we use header match type Exact in HttpRoute |
You can see the progress here |
@kostis-codefresh @mvishnevsky @cevret PR is ready. You can go to the PR and try it locally. Run make local-build and you will get binary to test. I also put the description to the PR to understand how it works |
Hi,
I was wondering if there is a plan or a roadmap for when the plugin will support the SetHeader option.
Thank you!
The text was updated successfully, but these errors were encountered: