Config map ref broken while upgrading to 0.1.0 version from 0.0.1

[komal-SkyNET]

Error from the argo-controller pods after upgrading to v0.1.0

time="2024-02-13T06:47:11Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=info msg="Reconciling TrafficRouting with type 'GatewayAPI'" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=error msg="roCtx.reconcile err failed to remove managed routes via plugin: configmaps \"argo-gatewayapi-configmap\" not found" generation=2 namespace=test-argo-gamma resourceVersion=348232258 rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=info msg="Reconciliation completed" generation=2 namespace=test-argo-gamma resourceVersion=348232258 rollout=gap-app-argo time_ms=23.592025
time="2024-02-13T06:47:11Z" level=error msg="rollout syncHandler error: failed to remove managed routes via plugin: configmaps \"argo-gatewayapi-configmap\" not found" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=info msg="rollout syncHandler queue retries: 38 : key \"test-argo-gamma/gap-app-argo\"" namespace=test-argo-gamma rollout=gap-app-argo
time="2024-02-13T06:47:11Z" level=error msg="failed to remove managed routes via plugin: configmaps \"argo-gatewayapi-configmap\" not found\n" error="<nil>"

apiVersion: v1
kind: ConfigMap
metadata:
  name: argo-rollouts-config 
  namespace: argo-rollouts 
data:
  trafficRouterPlugins: |-
    - name: "argoproj-labs/gatewayAPI"
      location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.1.0/gateway-api-plugin-linux-amd64"

Reverting back to v0.0.1 works fine.

Is there a ReadME with instructions for the upgrade to 0.1.0? How can I help?

[komal-SkyNET]

I can see that the new plugin somehow overrides the configmap name and has controller looking at this name argo-gatewayapi-configmap
v0.0.1...v0.1.0#diff-70ed1cb27bccfc830b942edf26a9a4107c1a42545d58536e1fdbcd6bdaad6cb5R3

[Philipp-Plotnikov]

@komal-SkyNET hi! Can you check,was config map created ? And in what namespace ?
And can you show argo-rollout manifest, please ?

[Philipp-Plotnikov]

I can see that the new plugin somehow overrides the configmap name and has controller looking at this name argo-gatewayapi-configmap

v0.0.1...v0.1.0#diff-70ed1cb27bccfc830b942edf26a9a4107c1a42545d58536e1fdbcd6bdaad6cb5R3

It is the default config map name if you don't specify it

[komal-SkyNET]

@Philipp-Plotnikov Can you please share a sample config? The configmap has been created and it uses the same name as the previous version argo-rollouts-config. I'm finding it hard to figure out where you specify the plugin configmap name.

I have a config similar to the readme (latest version instead of 0.1.0)

apiVersion: v1
kind: ConfigMap
metadata:
  name: argo-rollouts-config # must be so name
  namespace: argo-rollouts # must be in this namespace
data:
  trafficRouterPlugins: |-
    - name: "argoproj-labs/gatewayAPI"
      location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.0.0-rc1/gateway-api-plugin-linux-amd64"

Questions:

1. Where do you specify configmap name for argo-controller to look?
2. Can you share a sample config or update the readme to align with the latest version, please?

[Philipp-Plotnikov]

@komal-SkyNET you should have another config map like here in the example
#31

[Philipp-Plotnikov]

It will be great if you share the argo rollouts manifest and say do you see in the cluster created config map that you specified. I have assumption you dont have step with setHeaderRoute, am I right ? If yes, then I think I know what is the reason

[Philipp-Plotnikov]

@komal-SkyNET I think my assumption is right, so I have created PR with the fix. Can you test it, please ? You need to switch to the branch and run in the root "make local-build" and you will get binary to test
#37

[komal-SkyNET]

@Philipp-Plotnikov That's correct. I'm not using any new features from the new version. Don't have a setHeaderRoute. Just bumping up the version from 0.0.1 to 0.1.0. But I can you have figured out the bug, thanks for that. Will have a play later today. Cheers,

[Philipp-Plotnikov]

@komal-SkyNET have you tried updated version from PR that I have sent ? Has it helped you ?