-
Notifications
You must be signed in to change notification settings - Fork 45
[EDU-2044] - Remove SDK set up pages and redirect to getting started landing pages #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDU-2044] - Remove SDK set up pages and redirect to getting started landing pages #2830
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
59c448e
to
7733a01
Compare
8ed90ba
to
2ccdebb
Compare
20c9a96
to
f7c5286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general points (or thoughts).
- IS the redirect to the landing page is sufficient?
- should there be "middle ground" redirects to language-specific pages for the same links?
and
- I think the general structure could be more similar between pub/sub and chat "getting started" landing pages.
- and consistent tile ordering
And agree with waht @m-hulbert commented also :)
63aae82
to
3a2658b
Compare
Thanks @m-hulbert I've made the changes recommended. @franrob-projects If I understand correctly on your first point, you're recommending that we implement some sort of functionality that checks whether the lang param the user has when accessing sdk set up page should determine at the point of redirect which getting started page they go to? It's possible, but I'm not sure it's worth the effort right now. Redirects are a temperamental setup. Redirecting the user just to the getting started landing page only exposes them to the tiles of all the getting started guides available. On your section comment:
I'm not sure I understand. They are very simple pages. I had to add sub headers in the Chat one as we broke the React UI component guide away from the standard getting started guides. Other than that there's no difference. The tile ordering is consistent too. If you compare the two, Pub/Sub has (in exact order):
Chat has (in order):
I apologise if I misunderstood but was this the part you referring to in inconsistent tile ordering? |
d26eee6
to
f467473
Compare
Yes that I was I was refering to.
There is |
Yep, I noticed that while responding to you and added it as a new commit. But I'm not sure what you meant by The tile ordering is consistent too, it's just that one was missing at the time you made the comment. |
… tile, redirect SDK set up to this page
f467473
to
20f3216
Compare
The point I'm making is:
So, I have my comment. Also, for a bit of extra consistency:
|
da76750
to
88803b0
Compare
0e5f8fd
to
cbe0398
Compare
Ok, that's the status, cool!! |
Description
This PR: