Repository navigation
fix(libero): expose grasp_status and mark pi0_pick success as motion heuristic only - #266
Open
akushonkamen wants to merge 1 commit into
Open
akushonkamen wants to merge 1 commit into
akushonkamen wants to merge 1 commit into
Conversation
…heuristic only pi0_pick set success from pure kinematics (descent done + post-descent ascent + gripper closure; default gripper_open_thresh=0.0), so closing the fingers on air also returned success=true and misled downstream transport/release decisions (RLinf#243). Keep the kinematic early-stop behavior unchanged, but: - add an honest "grasp_status: unknown" field to the pick result (no contact or held-object query exists; no privileged state is exposed) - rewrite the tool description and arg docs: success is a motion heuristic, a HINT not proof - align the evaluate prompt Rule 1b with the structured field - update the tool_schemas.json contract fixture (intentional declaration change) and add offline probe tests replaying the issue-243 trajectory against stubbed VLA/env boundaries
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #243.
Root cause.
pi0_pickreportedsuccessfrom a pure kinematic heuristic with no contact or held-object evidence:robots/libero/tools.py:213— defaultgripper_open_thresh=0.0makes the closure lower bound ineffective;robots/libero/tools.py:256— any grip< 0.06counts as "closed";robots/libero/tools.py:257-259— descent-done + post-descent ascent + closure ⇒success=True.So closing the fingers on air also returned
success=trueand misled downstream transport/release decisions.Fix (per the issue's Expected section; no existing behavior changed).
ToolResultdata gains an honestgrasp_status: "unknown"field (robots/libero/tools.py:273) — no contact/held-object query exists, and no privileged object state is exposed.successis motion-heuristic-only, a HINT not proof (robots/libero/tools.py:216).evaluate.pyRule 1b wording aligned to citegrasp_status(robots/libero/prompts/evaluate.py:209,219).tests/unit_tests/robots/fixtures/tool_schemas.jsoncontract fixture updated (libero/pi0_pick: description + 3 arg descriptions — intentional declaration change).Deliberately not done: simulation-based contact queries — the issue asks to align on that in the issue first, so it is not done unilaterally.
Testing
timeout 300 .venv/bin/python -m pytest tests/unit_tests/robots/libero/test_pi0_pick_grasp_status.py -q→ 7 failed (all missinggrasp_status/ contract mismatch).timeout 300 .venv/bin/python -m pytest tests/unit_tests/robots/libero/ -q→ 52 passed (baseline 45 + 7 new).mainbaselinetimeout 600 pytest tests/unit_tests/ -q→ 1209 passed, 7 skipped, 0 failed; this branch, same command → 1216 passed, 7 skipped, 0 failed (FAIL set empty both rounds; only +7 new tests, zero regressions).ruff check+ruff format --check(3 changed Python files) → All checks passed.064a179(origin/main unchanged, no rebase needed): green suite 52 passed, new test file 7 passed,ruff check/ruff format --checkon the 3 changed Python files → All checks passed.Manual verification
Not needed — offline unit tests fully cover the change (no GPU, simulator, or model service involved; simulation-based contact verification is intentionally deferred pending discussion in #243).
Checklist
Developed with AI assistance; full disclosure in the claim comment on #243.