Skip to content

test: cover REES render contract#2395

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
Florcitaq:render-contract-2037
Jul 2, 2026
Merged

test: cover REES render contract#2395
JSONbored merged 1 commit into
JSONbored:mainfrom
Florcitaq:render-contract-2037

Conversation

@Florcitaq

Copy link
Copy Markdown
Contributor

Closes #2037.

Summary

  • Adds a REES render contract test covering descriptor-owned rendering via dependency and the built-in fallback section path via �ctionPin.
  • Asserts empty finding lists produce no rendered prompt section.
  • Adds a pure �uildBrief fixture with an injected analyzer registry to prove partial analyzer results surface as degraded with partial telemetry.

Verification

pm run build

ode --test --experimental-strip-types "test/render-contract.test.ts"

pm run validate:sourcemaps

ode --test --experimental-strip-types "test/**/*.test.ts" passes the new render-contract test and 360/362 tests overall; the two failures are existing local sentry-upload.test.ts failures where sentry-cli releases ... new gittensory-rees@abc123 exits 1 in this environment.

pm test also currently stops early because generated analyzer metadata is stale in main; I did not include generated metadata drift in this test-only PR.

@Florcitaq
Florcitaq requested a review from JSONbored as a code owner July 1, 2026 15:42
@dosubot dosubot Bot added the size:XS label Jul 1, 2026
@loopover-orb

loopover-orb Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 04:15:22 UTC

1 file · 1 AI reviewer · no blockers · readiness 55/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR adds focused contract coverage for REES prompt rendering and partial analyzer propagation without changing production code. The tests exercise descriptor-owned rendering, the fallback renderer path, empty-section omission, and degraded telemetry for partial results through buildBrief. The visible change is coherent with the PR description and safe to proceed; no blocking defects are present in the diff.

Nits — 5 non-blocking
  • nit: review-enrichment/test/render-contract.test.ts:30 uses broad regex checks for the render contract, so duplicated, reordered, or extra sections could still pass.
  • nit: review-enrichment/test/render-contract.test.ts:49 covers partial propagation with only one analyzer result, so it does not prove mixed ok/degraded analyzer status aggregation stays intact.
  • review-enrichment/test/render-contract.test.ts:30: Consider asserting the full promptSection/systemSuffix shape or at least section boundaries/counts so this contract test catches duplicate or misplaced renderer output.
  • review-enrichment/test/render-contract.test.ts:49: Consider adding a second injected analyzer that returns a normal finding or no findings to prove one partial analyzer does not degrade unrelated analyzer statuses.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2037
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (size label size:XS; 1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 0 registered-repo PR(s), 0 merged, 0 issue(s).
Contributor context ❌ No public Gittensor match Florcitaq; not a blocker.
Gate result ✅ Passing No configured blocker found.
Review context
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@dosubot dosubot Bot added the lgtm label Jul 2, 2026
@JSONbored
JSONbored merged commit 853ec9a into JSONbored:main Jul 2, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

feat(enrichment): render section + analyzerStatus wiring test for new local analyzers

2 participants