test(crypto): cover uppercase hex in timingSafeEqualHex - #2111
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 223 223
Lines 24741 24741
Branches 8969 8969
=======================================
Hits 23685 23685
Misses 433 433
Partials 623 623 🚀 New features to boost your workflow:
|
|
Moving forward, please do not open more than 2 PRs at a time - i'll be adding a configuration to gittensory orb to auto-close PRs over that threshold. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-01 17:11:26 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
1550eea to
9aabec8
Compare
Lock in case-insensitive hex parsing used by webhook signature verification. Co-authored-by: Cursor <cursoragent@cursor.com>
9aabec8 to
ddea952
Compare
Summary
timingSafeEqualHextreats uppercase and lowercase hex as equal.No-issue rationale
Test-only coverage lock with no linked issue.
Test plan
npx vitest run test/unit/crypto.test.tsMade with Cursor