test(review): cover review-thread blocker title parsing

[bohdansolovie]

Summary

• Add unit tests for buildReviewThreadBlocker and reviewThreadBlockerFinding (scanner preference, markdown/XML priority markers, location formatting).

Test plan

• npx vitest run test/unit/review-thread-findings.test.ts

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-02 04:15:42 UTC}

1 file · 1 AI reviewer · no blockers · readiness 48/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This change adds focused unit coverage for review-thread finding parsing, including empty-comment handling, scanner-marked comment preference, markdown priority extraction, XML marker extraction, and location formatting when the line is not positive. The visible diff is test-only, the exercised assertions match the PR description, and there are no reachable production breakages in the provided files. The most notable gap is that one fixture includes a discussion URL without asserting whether that value is intentionally preserved or irrelevant.

Nits — 5 non-blocking

• nit: test/unit/review-thread-findings.test.ts:27 includes a `url` in the scanner-marked fixture but never asserts it, so either assert the returned link field if it is part of the blocker contract or remove the fixture noise.
• nit: test/unit/review-thread-findings.test.ts:38 combines XML parsing and advisory formatting in one test, which makes failures less local than separate parser and formatter cases would be.
• test/unit/review-thread-findings.test.ts:27: Assert the URL/link field when `buildReviewThreadBlocker` is expected to carry it through from the selected comment.
• test/unit/review-thread-findings.test.ts:38: Split XML marker parsing from `reviewThreadBlockerFinding` formatting so regressions point at the exact layer.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 140 registered-repo PR(s), 68 merged, 11 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bohdansolovie; Gittensor profile; 140 PR(s), 11 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: bohdansolovie
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 140 PR(s), 11 issue(s).
• Related work: Titles/paths share 6 meaningful terms. (PR #2376)
• Related work: Items reference the same linked issue feat(enrichment): render section + analyzerStatus wiring test for new local analyzers #2037. (issue #2037, PR #2395)
• Related work: Items reference the same linked issue test(enrichment): add flaky-test retry to the review-enrichment suite #2425. (issue #2425, PR #2436)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Explain no-issue PR.
• Review top overlaps.
• Add a concise scope and risk note.
• Await review-lane availability.
• Triage stale or unlinked PRs.
• Refresh registry data or choose a registered active repo.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.73%. Comparing base (17d70b2) to head (46cdb88).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   95.71%   95.73%   +0.01%     
==========================================
  Files         222      222              
  Lines       24661    24661              
  Branches     8949     8949              
==========================================
+ Hits        23605    23609       +4     
+ Misses        433      424       -9     
- Partials      623      628       +5     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JSONbored]

Fix this, then you can resubmit:

The most notable gap is that one fixture includes a discussion URL without asserting whether that value is intentionally preserved or irrelevant.