Skip to content

refactor: move Studio prepare, start, references and LoRAs to the slice - #52

Merged
IAnMove merged 2 commits into
mainfrom
refactor/paso3-studio-to-main
Sep 1, 2026
Merged

refactor: move Studio prepare, start, references and LoRAs to the slice#52
IAnMove merged 2 commits into
mainfrom
refactor/paso3-studio-to-main

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

#51 se mezcló en refactor/paso3-workspaces-to-main, no en main. Este PR es el mismo commit sobre origin/main 49baba3 (post #50 workspaces).

Studio generate sin queue_sfx_pack:

  • prepare_video / image / audio / 3d
  • start_generation
  • attach_studio_references / configure_studio_loras

Legacy 10→3. setState agent 0.

Mezclar en main. Dueño del merge: humano.


Note

Medium Risk
Refactors how the agent mutates Studio UI and enqueues generation jobs; behavior should be equivalent but both runners now depend on the new adapter/slice wiring.

Overview
Studio agent flows (prepare video/image/audio/3D, queue generation, attach references, configure LoRAs) are moved out of agentActions / studioGuidance into the studio slice (actions.ts, commands.ts, adapters.ts). Those operations now return structured CommandResult payloads (summary/title/mode/task id) instead of ad‑hoc strings.

The legacy action runner and Studio capabilities both call the same path via defaultApplicationAdapters.studio, with presentStudioSliceResult mapping slice results to adapter outcomes and execution reports. agentActions drops the inlined Studio logic and the old *ForAgent bridges; studioCapabilities no longer lazy-imports agentActions for most Studio actions (only queue_sfx_pack still bridges there).

Guardrail tests update the legacy-execute allowlist 10 → 3 actions still handled directly in executeAgentActions.

Reviewed by Cursor Bugbot for commit d032153. Configure here.

prepare_video, prepare_image, prepare_audio, prepare_3d, start_generation,
attach_studio_references and configure_studio_loras execute through
context.adapters.studio. queue_sfx_pack stays legacy for a follow-up PR.
Legacy executors drop from 10 to 3.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: medium
Scope: 9 file(s); +692/-562; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • medium — Very large file change (ui/src/features/studio/actions.ts)
    ui/src/features/studio/actions.ts adds 465 lines. Consider splitting the PR.
  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/studio/actions.ts
  • modified: ui/src/features/agent/agentActions.ts, ui/src/features/agent/applicationAdapters.ts, ui/src/features/agent/audioActions.ts, ui/src/features/agent/studioCapabilities.ts, ui/src/features/agent/studioGuidance.ts, ui/src/features/studio/adapters.ts, ui/src/features/studio/commands.ts, ui/tests/agentCapabilityPorts.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 70ebe11. Configure here.

queue_sfx_pack still uses the legacy bridge; the unused context
argument tripped eslint unused-vars on CI.
@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

Lint CI: _context unused en bridgeSfx. Push d032153 lo quita. Mezclar en main (no en rama apilada).

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit d032153. Configure here.

@IAnMove
IAnMove merged commit f40ac4c into main Sep 1, 2026
5 checks passed
@IAnMove
IAnMove deleted the refactor/paso3-studio-to-main branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant