refactor: move Studio prepare, start, references and LoRAs to the slice - #52
Conversation
prepare_video, prepare_image, prepare_audio, prepare_3d, start_generation, attach_studio_references and configure_studio_loras execute through context.adapters.studio. queue_sfx_pack stays legacy for a follow-up PR. Legacy executors drop from 10 to 3.
PR Review — Loreframe StudioRisk: medium Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 70ebe11. Configure here.
queue_sfx_pack still uses the legacy bridge; the unused context argument tripped eslint unused-vars on CI.
|
cursor review Lint CI: |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d032153. Configure here.
Qué
#51 se mezcló en
refactor/paso3-workspaces-to-main, no enmain. Este PR es el mismo commit sobreorigin/main49baba3(post #50 workspaces).Studio generate sin
queue_sfx_pack:Legacy 10→3.
setStateagent 0.Mezclar en main. Dueño del merge: humano.
Note
Medium Risk
Refactors how the agent mutates Studio UI and enqueues generation jobs; behavior should be equivalent but both runners now depend on the new adapter/slice wiring.
Overview
Studio agent flows (prepare video/image/audio/3D, queue generation, attach references, configure LoRAs) are moved out of
agentActions/studioGuidanceinto thestudioslice (actions.ts,commands.ts,adapters.ts). Those operations now return structuredCommandResultpayloads (summary/title/mode/task id) instead of ad‑hoc strings.The legacy action runner and Studio capabilities both call the same path via
defaultApplicationAdapters.studio, withpresentStudioSliceResultmapping slice results to adapter outcomes and execution reports.agentActionsdrops the inlined Studio logic and the old*ForAgentbridges;studioCapabilitiesno longer lazy-importsagentActionsfor most Studio actions (onlyqueue_sfx_packstill bridges there).Guardrail tests update the legacy-execute allowlist 10 → 3 actions still handled directly in
executeAgentActions.Reviewed by Cursor Bugbot for commit d032153. Configure here.