Skip to content

refactor: run queue_sfx_pack through the Studio slice adapter - #53

Merged
IAnMove merged 2 commits into
mainfrom
refactor/paso3-sfx
Sep 1, 2026
Merged

refactor: run queue_sfx_pack through the Studio slice adapter#53
IAnMove merged 2 commits into
mainfrom
refactor/paso3-sfx

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

PR pequeño Codex: Audio / queue_sfx_pack.

Incluye #52 (Studio generate) si aún no está en main. Mezclar este PR en main, no en una rama apilada.

Legacy 3→2 (solo canciones alternativas).

Dueño del merge: humano.


Note

Medium Risk
Touches GPU queueing, Hunyuan3D jobs, and Studio form state across both capability and legacy runners; start_generation execution reports now mark recoverable as true where the adapter builds the report.

Overview
Consolidates Wizard Studio work (prepare video/image/audio/3D, queue generation, SFX packs, references, LoRAs) behind the features/studio slice instead of inline logic in agentActions, audioActions, and studioGuidance.

Form mutations and queueing now live in studio/actions.ts, return CommandResult summaries, and are reached via studio/adaptersdefaultApplicationAdapters.studio. The legacy agentActions bridges and studioCapabilities bridge lazy-imports are removed; registered capabilities call context.adapters.studio.*, and the legacy executor in executeAgentActions delegates the same way and forwards report on results.

audioActions only thin-wraps studio prepare for music queueing; studioGuidance re-exports studio actions. agentCapabilityPorts shrinks the legacy execute allowlist from 10 → 2 (videoclip alternative song only).

Reviewed by Cursor Bugbot for commit 3e988f6. Configure here.

Move SFX pack enqueue into features/studio and execute it via
context.adapters.studio.queueSfxPack. Legacy executors drop from 3 to 2.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 8 file(s); +63/-52; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • modified: ui/src/features/agent/agentActions.ts, ui/src/features/agent/applicationAdapters.ts, ui/src/features/agent/audioActions.ts, ui/src/features/agent/studioCapabilities.ts, ui/src/features/studio/actions.ts, ui/src/features/studio/adapters.ts, ui/src/features/studio/commands.ts, ui/tests/agentCapabilityPorts.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

Mezclar en main después de #52, no en una rama apilada.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3e988f6. Configure here.

# Conflicts:
#	ui/src/features/agent/studioCapabilities.ts
@IAnMove
IAnMove merged commit 47283b1 into main Sep 1, 2026
4 checks passed
@IAnMove
IAnMove deleted the refactor/paso3-sfx branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant