refactor: run queue_sfx_pack through the Studio slice adapter - #53
Merged
Conversation
Move SFX pack enqueue into features/studio and execute it via context.adapters.studio.queueSfxPack. Legacy executors drop from 3 to 2.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review Mezclar en main después de #52, no en una rama apilada. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3e988f6. Configure here.
# Conflicts: # ui/src/features/agent/studioCapabilities.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
PR pequeño Codex: Audio /
queue_sfx_pack.Incluye #52 (Studio generate) si aún no está en
main. Mezclar este PR en main, no en una rama apilada.Legacy 3→2 (solo canciones alternativas).
Dueño del merge: humano.
Note
Medium Risk
Touches GPU queueing, Hunyuan3D jobs, and Studio form state across both capability and legacy runners;
start_generationexecution reports now mark recoverable as true where the adapter builds the report.Overview
Consolidates Wizard Studio work (prepare video/image/audio/3D, queue generation, SFX packs, references, LoRAs) behind the
features/studioslice instead of inline logic inagentActions,audioActions, andstudioGuidance.Form mutations and queueing now live in
studio/actions.ts, returnCommandResultsummaries, and are reached viastudio/adapters→defaultApplicationAdapters.studio. The legacyagentActionsbridges andstudioCapabilitiesbridgelazy-imports are removed; registered capabilities callcontext.adapters.studio.*, and the legacy executor inexecuteAgentActionsdelegates the same way and forwardsreporton results.audioActionsonly thin-wraps studio prepare for music queueing;studioGuidancere-exports studio actions.agentCapabilityPortsshrinks the legacy execute allowlist from 10 → 2 (videoclip alternative song only).Reviewed by Cursor Bugbot for commit 3e988f6. Configure here.