refactor: move alternative song attach and remount into videoclips - #54
Merged
Conversation
attach_videoclip_alternative_song and mount_videoclip_alternative_song return CommandResult from features/videoclips and execute through context.adapters.videoclips. Legacy executors drop to 0.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 75f592a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
PR pequeño Codex: canciones alternativas attach/remount.
Incluye #52 y #53 si aún no están en
main. Mezclar este PR en main, no en una rama apilada.attach_videoclip_alternative_songymount_videoclip_alternative_songsalen de Agent Mode haciafeatures/videoclipsy ejecutan porcontext.adapters.videoclips.Legacy 2→0. slice→agent sigue en 4 listeners (siguiente PR).
Dueño del merge: humano. No mezclar #48.
Note
Medium Risk
Touches all agent paths that mutate Studio forms and queue GPU jobs plus videoclip FFmpeg mounts; behavior is largely a move, but any adapter/presentation drift could affect execution reports or navigation.
Overview
This PR finishes the agent “slice port” migration for Studio prep/queue flows and videoclip alternative songs: implementation moves out of
agentActions/alternativeSongActionsintofeatures/studioandfeatures/videoclips, and both the legacyexecuteAgentActionsrunner and the capability registry call the samedefaultApplicationAdapterspaths.Studio:
prepare_video,prepare_image,prepare_audio,prepare_3d,queue_sfx_pack,start_generation,attach_studio_references, andconfigure_studio_lorasnow live instudio/actions.ts(returningCommandResult), wired viastudio/adapters.ts.studioCapabilitiesdrops the lazyagentActionsbridge;studioGuidancebecomes a re-export. Agent steps pushmessage+reportfrom adapter outcomes (including queued generation withexecutionKey).Videoclips: attach/mount logic moves to
videoclips/actions.ts; capabilities usecontext.adapters.videoclipswith reuse/rememberExecutionon mount.alternativeSongActions.tskeeps only action type definitions.Contract tests expect zero remaining legacy inline executors and add
videoclipsto the default adapter surface.Reviewed by Cursor Bugbot for commit 75f592a. Configure here.