Skip to content

refactor: move alternative song attach and remount into videoclips - #54

Merged
IAnMove merged 2 commits into
mainfrom
refactor/paso3-alternative-songs
Sep 1, 2026
Merged

refactor: move alternative song attach and remount into videoclips#54
IAnMove merged 2 commits into
mainfrom
refactor/paso3-alternative-songs

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

PR pequeño Codex: canciones alternativas attach/remount.

Incluye #52 y #53 si aún no están en main. Mezclar este PR en main, no en una rama apilada.

attach_videoclip_alternative_song y mount_videoclip_alternative_song salen de Agent Mode hacia features/videoclips y ejecutan por context.adapters.videoclips.

Legacy 2→0. slice→agent sigue en 4 listeners (siguiente PR).

Dueño del merge: humano. No mezclar #48.


Note

Medium Risk
Touches all agent paths that mutate Studio forms and queue GPU jobs plus videoclip FFmpeg mounts; behavior is largely a move, but any adapter/presentation drift could affect execution reports or navigation.

Overview
This PR finishes the agent “slice port” migration for Studio prep/queue flows and videoclip alternative songs: implementation moves out of agentActions / alternativeSongActions into features/studio and features/videoclips, and both the legacy executeAgentActions runner and the capability registry call the same defaultApplicationAdapters paths.

Studio: prepare_video, prepare_image, prepare_audio, prepare_3d, queue_sfx_pack, start_generation, attach_studio_references, and configure_studio_loras now live in studio/actions.ts (returning CommandResult), wired via studio/adapters.ts. studioCapabilities drops the lazy agentActions bridge; studioGuidance becomes a re-export. Agent steps push message + report from adapter outcomes (including queued generation with executionKey).

Videoclips: attach/mount logic moves to videoclips/actions.ts; capabilities use context.adapters.videoclips with reuse/rememberExecution on mount. alternativeSongActions.ts keeps only action type definitions.

Contract tests expect zero remaining legacy inline executors and add videoclips to the default adapter surface.

Reviewed by Cursor Bugbot for commit 75f592a. Configure here.

attach_videoclip_alternative_song and mount_videoclip_alternative_song
return CommandResult from features/videoclips and execute through
context.adapters.videoclips. Legacy executors drop to 0.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 8 file(s); +225/-143; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/src/features/videoclips/actions.ts, ui/src/features/videoclips/adapters.ts, ui/src/features/videoclips/commands.ts
  • modified: ui/src/features/agent/alternativeSongActions.ts, ui/src/features/agent/applicationAdapters.ts, ui/src/features/agent/capabilityRegistry.ts, ui/tests/agentCapabilityPorts.test.mjs, ui/tests/agentContract.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

Mezclar en main después de #52 y #53, no en una rama apilada.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 75f592a. Configure here.

@IAnMove
IAnMove merged commit 8c64438 into main Sep 1, 2026
4 checks passed
@IAnMove
IAnMove deleted the refactor/paso3-alternative-songs branch September 5, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant