refactor: move Studio prepare, start, references and LoRAs to the slice - #51
Merged
IAnMove merged 1 commit intoSep 1, 2026
Conversation
prepare_video, prepare_image, prepare_audio, prepare_3d, start_generation, attach_studio_references and configure_studio_loras execute through context.adapters.studio. queue_sfx_pack stays legacy for a follow-up PR. Legacy executors drop from 10 to 3.
Owner
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 982d419. Configure here.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Apilado sobre #50 (workspaces en
main). Codex: PR pequeño de Studio sinqueue_sfx_pack.prepare_video/prepare_image/prepare_audio/prepare_3dstart_generationattach_studio_references/configure_studio_lorasvan a
features/studio(CommandResult) ycontext.adapters.studio.*.Legacy 10→3 (
queue_sfx_pack+ 2 canciones alternativas).setStateagent sigue 0.Mezclar después de #50. Dueño del merge: humano.
Verificación
agentCapabilityPorts+agentActions+agentContract+storyComicProgresslocales verdes. Reuse destart_generationconservaexecutionKey.Note
Medium Risk
Refactors paths that mutate Studio state and enqueue GPU jobs; behavior is mostly relocated, but regressions in adapter presentation or execution reports could affect agent reuse and queue correlation.
Overview
Moves Wizard Studio form prep, queueing, references, and LoRAs out of
agentActionsintofeatures/studio, with shared logic inactions.ts, typed commands incommands.ts, and thin entry points inadapters.ts. Outcomes are nowCommandResultslices (summary/title/mode metadata) instead of ad‑hoc strings.The legacy action runner and registered Studio capabilities both go through
defaultApplicationAdapters.studio.*(prepareVideo/Image/Audio/3d,startGeneration,attachReferences,configureLoras), withpresentStudioSliceResultnavigating to Studio and mapping entities tostudio_form/generation_tasktargets.studioCapabilitiesno longer lazy‑bridges toagentActions(exceptqueue_sfx_pack);studioGuidanceandaudioActions.prepareAudiodelegate to the studio slice.agentActionsdrops ~260 lines of inline Studio UI mutation and removed*ForAgentbridges;agentCapabilityPortslegacy allowlist shrinks 10 → 3 (SFX pack + two videoclip song actions).start_generationstill buildsexecutionKeyin the adapter for reuse.Reviewed by Cursor Bugbot for commit 982d419. Configure here.