fix(assets): land orphan Labs and Tools voice-ref fixes on development - #222
Merged
Conversation
…resolve refs
ensureUploadsPath returned uploads/${name} for already-uploaded images.
Auto-describe resolves relative names under the uploads root, so that
path became uploads/uploads/${name} and the default empty-prompt orbit
flow 400'd. Always copy through /api/v1/upload and keep the absolute
path the upload API already returns.
Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
AssetInput stores the upload filename, but /api/v1/upload-audio writes into uploads/audio/. Revoice 404'd and SeedVC silently skipped the clone. Keep the audio/ prefix via getServerMediaReference and resolve clone refs before applying them. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
25 tasks
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_fca6a3f3-4c5a-4cbc-94c1-bcab5d419b26) |
25 tasks
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.2/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks two Cursor fixes that were merged into already-merged feature branches, so they never reached
development:feat/asset-picker-labs) — Character Creator / Labs picks must copy through/api/v1/uploadfor an absolute path.feat/asset-picker-6a-remainder) — voice refs keep theuploads/audio/prefix the backend can resolve.Both cherry-picks applied cleanly on current
origin/development(5b4e6334, includes #217).Do not merge until asked. After this lands, #221 can be closed as duplicate.
Test plan
tests/labsImagePick.test.mjs— 2 passedtests/assetPickerContract.test.ts— 18 passed (includes voice-ref path)Older stacked PRs
feat/3d-compositor-recipe, then that stack did land (commits are ancestors ofdevelopment).development/main(likely squash), but the studio/workspace slice files exist ondevelopmenttoday. Not included here.Coste de la tarea
Note
Medium Risk
Touches generation post-processing path resolution and shared Labs upload plumbing; changes are scoped but affect voice clone and Character Creator/Series import flows.
Overview
Fixes two asset-picker gaps that broke voice clone / revoice and Labs image picks when paths did not match what the server expects.
Voice references: Post-processing and Tools now store server-relative paths via
voiceRefFromOutput(e.g.audio/9f2.wavfor uploads underuploads/audio/, workspace filenames unchanged). Generation resolvesvoice_clone_refsthrough newresolve_voice_ref_paths, which confines paths to uploads/workspace, accepts audio/video, and drops invalid or missing refs so stale picks do not abort SeedVC.Labs / Series images:
ensureUploadsPathalways fetches the asset and POSTs to/api/v1/upload, returning the API’s absolute path. The previous shortcut for items already under/api/v1/uploads/produced relative paths likeuploads/hero.pngthat downstream describe/import logic resolved incorrectly (e.g.uploads/uploads/...and 400s).Tests cover upload subdir resolution, voice-ref filtering, and the updated upload-copy behavior in unit and Series picker flows.
Reviewed by Cursor Bugbot for commit c7cd378. Configure here.