Skip to content

refactor: run workspace select and create through slice adapters - #50

Merged
IAnMove merged 1 commit into
mainfrom
refactor/paso3-workspaces-to-main
Sep 1, 2026
Merged

refactor: run workspace select and create through slice adapters#50
IAnMove merged 1 commit into
mainfrom
refactor/paso3-workspaces-to-main

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Qué

#49 se mezcló en refactor/paso3-queue, no en main. Este PR es el mismo commit sobre origin/main c589c4a (post #45).

  • select_workspace / create_workspace vía context.adapters.workspace.
  • Slice workspaces devuelve CommandResult.
  • Legacy 12→10. setState agent sigue en 0.

Mezclar antes de Studio generate. Dueño del merge: humano. No mezclar #48.

Verificación

Gate local: agentCapabilityPorts + navigationQueueCapabilities + storyComicProgress 11 pass.


Note

Medium Risk
Switching active workspace changes where chat and generations run; behavior is refactored but still depends on store/API confirmation paths.

Overview
Agent workspace actions (select_workspace / create_workspace) no longer call workspaceActions directly. They go through a new context.adapters.workspace port, matching queue and other slices.

The workspaces slice now returns structured CommandResult (entity + summary artifact) instead of plain strings; applicationAdapters maps that via presentWorkspaceSliceResult into messages and workspace execution targets. Legacy branches in agentActions and navigationQueueCapabilities delegate to the adapter and can attach report on success.

Port tests drop those two types from the legacy executor allowlist (12→10), expect a workspace key on default adapters, and add coverage that capabilities call the injected workspace adapter.

Reviewed by Cursor Bugbot for commit 3df0054. Configure here.

select_workspace and create_workspace now return CommandResult from the
workspaces slice and execute via context.adapters.workspace. Legacy
executors drop from 12 to 10.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 8 file(s); +108/-32; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • modified: ui/src/features/agent/agentActions.ts, ui/src/features/agent/applicationAdapters.ts, ui/src/features/agent/navigationQueueCapabilities.ts, ui/src/features/workspaces/actions.ts, ui/src/features/workspaces/adapters.ts, ui/tests/agentCapabilityPorts.test.mjs, ui/tests/agentContract.test.mjs, ui/tests/navigationQueueCapabilities.test.mjs

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@IAnMove

IAnMove commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3df0054. Configure here.

@IAnMove
IAnMove merged commit 49baba3 into main Sep 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant