refactor: run workspace select and create through slice adapters - #50
Merged
Conversation
select_workspace and create_workspace now return CommandResult from the workspaces slice and execute via context.adapters.workspace. Legacy executors drop from 12 to 10.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review |
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3df0054. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
#49 se mezcló en
refactor/paso3-queue, no enmain. Este PR es el mismo commit sobreorigin/mainc589c4a(post #45).select_workspace/create_workspacevíacontext.adapters.workspace.workspacesdevuelveCommandResult.setStateagent sigue en 0.Mezclar antes de Studio generate. Dueño del merge: humano. No mezclar #48.
Verificación
Gate local:
agentCapabilityPorts+navigationQueueCapabilities+storyComicProgress11 pass.Note
Medium Risk
Switching active workspace changes where chat and generations run; behavior is refactored but still depends on store/API confirmation paths.
Overview
Agent workspace actions (
select_workspace/create_workspace) no longer callworkspaceActionsdirectly. They go through a newcontext.adapters.workspaceport, matching queue and other slices.The workspaces slice now returns structured
CommandResult(entity + summary artifact) instead of plain strings;applicationAdaptersmaps that viapresentWorkspaceSliceResultinto messages andworkspaceexecution targets. Legacy branches inagentActionsandnavigationQueueCapabilitiesdelegate to the adapter and can attachreporton success.Port tests drop those two types from the legacy executor allowlist (12→10), expect a
workspacekey on default adapters, and add coverage that capabilities call the injected workspace adapter.Reviewed by Cursor Bugbot for commit 3df0054. Configure here.