Fix build wheels workflow to allow triggering it on workflow dispatch #21985
+89
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
The following files, which will be shipped with the agent, were modified in this PR and You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label. List of modified files that will be shipped with the agent |
This reverts commit 71154ef.
AAraKKe
changed the title
lucia-sb
previously approved these changes
Nov 28, 2025
iliakur
reviewed
Nov 28, 2025
HadhemiDD
previously approved these changes
Nov 28, 2025
iliakur
previously approved these changes
Dec 1, 2025
temporal-github-worker-1
bot
dismissed stale reviews from lucia-sb, HadhemiDD, and iliakur
Review from lucia-sb is dismissed. Related teams and files:
- agent-integrations
- .github/workflows/resolve-build-deps.yaml
- .github/workflows/scripts/resolve_deps_check_should_run.sh
- .github/workflows/scripts/resolve_deps_define_diff_commits.sh
Review from HadhemiDD is dismissed. Related teams and files:
- agent-integrations
- .github/workflows/resolve-build-deps.yaml
- .github/workflows/scripts/resolve_deps_check_should_run.sh
- .github/workflows/scripts/resolve_deps_define_diff_commits.sh
Review from iliakur is dismissed. Related teams and files:
- agent-integrations
- .github/workflows/resolve-build-deps.yaml
- .github/workflows/scripts/resolve_deps_check_should_run.sh
- .github/workflows/scripts/resolve_deps_define_diff_commits.sh
iliakur
approved these changes
Dec 2, 2025
Contributor
iliakur
left a comment
iliakur
left a comment
There was a problem hiding this comment.
Sooo much easier to read the workflow file now!
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.74.x 7.74.x
# Navigate to the new working tree
cd .worktrees/backport-7.74.x
# Create a new branch
git switch --create backport-21985-to-7.74.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 15351d3c2121a5a3c6b4c7a43f403a20447b0d58
# Push it to GitHub
git push --set-upstream origin backport-21985-to-7.74.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.74.xThen, create a pull request where the |
AAraKKe
added a commit
that referenced
this pull request
Dec 5, 2025
…#21985) * Fix build wheels workflow to allow running on dispatch * Ensure image digest is persisted if we are going to build and lock files * Unindent EOF * Pin krb5 to avoid the failed build * Revert "Pin krb5 to avoid the failed build" This reverts commit 71154ef. * Try new krb5 pin * wip: Work in Progress * Add back dependency on dcb alongside requests-kerberos * Remove pin and opened a separate PR for that * Remove redundant if condition and chomping pipes * Extract complex logic to separate bash scripts * Ensure we checkout the repo to get the scritps
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the build wheels workflow to allow us running it on
workflow_dispatch.The way this work is as follows:
We decide this based on the
Check if build should runjob. This job will skip the files changed validation on workflow dispatch, which is more expensive, and define the following variables:should_run_build=truebuilder_changed=falseThis ensures that we do not rebuild builders when running on demand, which is only done to build wheels but triggers the build down the line.
If we are running on a push or PR,
builder_changedwill only be true if we have modified the builders code and a new image needs to be recreated. Theshould_run_buildvariable is set to true only if we have modified theagent_requirements.infile or if the builders have changed (since we need to make sure to build with the latest version).Motivation
We recently updated it to be able to run always, since we need it to always run to produce a standard workflow when generating sizes (i.e. run sizes calculation after this finishes and use the sizes built by it when needed or not but ensure it always finish running before size calculation starts).
We forgot that we need to be able to run this workflow also on demand if we need to resolve dependencies in master or a release branch. This changes brings back this feature while maintaining what we need.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged