-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Backport 21985 : Fix build wheels #22045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: Define diff commits | ||
| id: set_sha | ||
| run: | | ||
| if [ "${{ github.event_name }}" == "pull_request" ]; then | ||
| PREV_SHA=${{ github.event.pull_request.base.sha }} | ||
| CURR_SHA=${{ github.event.pull_request.head.sha }} | ||
| else | ||
| PREV_SHA=${{ github.event.before }} | ||
| CURR_SHA=${{ github.sha }} | ||
| fi | ||
| echo "prev_sha=$PREV_SHA" >> $GITHUB_OUTPUT | ||
| echo "curr_sha=$CURR_SHA" >> $GITHUB_OUTPUT | ||
| echo "Current SHA: $CURR_SHA" | ||
| echo "Previous SHA: $PREV_SHA" | ||
| if: github.event_name != 'workflow_dispatch' | ||
| run: .github/workflows/scripts/resolve_deps_define_diff_commits.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference missing workflow scripts
The new check-should-run job now calls .github/workflows/scripts/resolve_deps_define_diff_commits.sh (and later resolve_deps_check_should_run.sh), but neither script exists in .github/workflows/scripts (only build_placeholders.sh and explode-matrix.py are present). When this workflow runs, the step at these lines will fail with “No such file or directory”, preventing dependency detection and blocking all downstream build/publish jobs.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
What does this PR do?
Update the changes in this PRs to 7.74:
21985 : Fix build wheels workflow to allow triggering it on workflow dispatch
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged