Skip to content

Conversation

@HadhemiDD
Copy link
Contributor

@HadhemiDD HadhemiDD commented Dec 4, 2025

What does this PR do?

Update the changes in this PRs to 7.74:
21985 : Fix build wheels workflow to allow triggering it on workflow dispatch

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 44 to +51
- name: Define diff commits
id: set_sha
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
PREV_SHA=${{ github.event.pull_request.base.sha }}
CURR_SHA=${{ github.event.pull_request.head.sha }}
else
PREV_SHA=${{ github.event.before }}
CURR_SHA=${{ github.sha }}
fi
echo "prev_sha=$PREV_SHA" >> $GITHUB_OUTPUT
echo "curr_sha=$CURR_SHA" >> $GITHUB_OUTPUT
echo "Current SHA: $CURR_SHA"
echo "Previous SHA: $PREV_SHA"
if: github.event_name != 'workflow_dispatch'
run: .github/workflows/scripts/resolve_deps_define_diff_commits.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reference missing workflow scripts

The new check-should-run job now calls .github/workflows/scripts/resolve_deps_define_diff_commits.sh (and later resolve_deps_check_should_run.sh), but neither script exists in .github/workflows/scripts (only build_placeholders.sh and explode-matrix.py are present). When this workflow runs, the step at these lines will fail with “No such file or directory”, preventing dependency detection and blocking all downstream build/publish jobs.

Useful? React with 👍 / 👎.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (7.74.x@84ede81). Learn more about missing BASE report.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HadhemiDD HadhemiDD changed the title Backport 22037 : Update python version Backport 21985 : Fix build wheels Dec 5, 2025
@HadhemiDD HadhemiDD merged commit 715ffae into 7.74.x Dec 5, 2025
27 checks passed
@HadhemiDD HadhemiDD deleted the backport-22037-to-7.74.x branch December 5, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants