-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix build wheels workflow to allow triggering it on workflow dispatch #21985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+89
−73
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8007374
Fix build wheels workflow to allow running on dispatch
AAraKKe 8a11c83
Ensure image digest is persisted if we are going to build and lock files
AAraKKe d1a4545
Unindent EOF
AAraKKe 71154ef
Pin krb5 to avoid the failed build
AAraKKe 8e779f0
Revert "Pin krb5 to avoid the failed build"
AAraKKe 89ed520
Try new krb5 pin
AAraKKe 991fac7
wip: Work in Progress
AAraKKe 02a7347
Add back dependency on dcb alongside requests-kerberos
AAraKKe 8bbfabd
Remove pin and opened a separate PR for that
AAraKKe b308a99
Merge branch 'master' into aarakke/fix-build-wheels-job
AAraKKe cce5c6b
Remove redundant if condition and chomping pipes
AAraKKe 2424ac2
Merge remote-tracking branch 'origin/master' into aarakke/fix-build-w…
AAraKKe 5d259a6
Extract complex logic to separate bash scripts
AAraKKe 8ae9642
Ensure we checkout the repo to get the scritps
AAraKKe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
.github/workflows/scripts/resolve_deps_check_should_run.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #!/bin/bash | ||
|
|
||
| if [ "$GITHUB_EVENT_NAME" == 'workflow_dispatch' ]; then | ||
| builder_changed="false" | ||
| should_run_build="true" | ||
| else | ||
|
|
||
| cat << EOF > dependency_files.txt | ||
| agent_requirements\.in | ||
| \.github/workflows/resolve-build-deps\.yaml | ||
| \.builders/ | ||
| EOF | ||
|
|
||
| cat <<EOF > builder_files.txt | ||
| \.builders/ | ||
| EOF | ||
|
|
||
| should_run_build=$( | ||
| echo "$FILES_CHANGED" | \ | ||
| grep -qf dependency_files.txt \ | ||
| && echo "true" || echo "false" | ||
| ) | ||
|
|
||
| builder_changed=$( | ||
| echo "$FILES_CHANGED" | \ | ||
| grep -qf builder_files.txt \ | ||
| && echo "true" || echo "false" | ||
| ) | ||
| fi | ||
|
|
||
| echo "should_run_build=$should_run_build" | tee -a $GITHUB_OUTPUT | ||
| echo "builder_changed=$builder_changed" | tee -a $GITHUB_OUTPUT | ||
15 changes: 15 additions & 0 deletions
15
.github/workflows/scripts/resolve_deps_define_diff_commits.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #!/bin/bash | ||
|
|
||
| if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then | ||
| prev_sha=$PR_BASE_SHA | ||
| curr_sha=$PR_HEAD_SHA | ||
| else | ||
| prev_sha=$EVENT_BEFORE | ||
| curr_sha=$GITHUB_SHA | ||
| fi | ||
|
|
||
| echo "prev_sha=$prev_sha" >> $GITHUB_OUTPUT | ||
| echo "curr_sha=$curr_sha" >> $GITHUB_OUTPUT | ||
|
|
||
| echo "Current SHA: $curr_sha" | ||
| echo "Previous SHA: $prev_sha" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.