Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider implementations currently register roles, constructors, credential metadata, and capabilities separately. This adds
providers.Register[T](name, Definition{...})to collect that information in one definition and derive initialization, auditing, roles, and zone operations from the implementation's interfaces.CLOUDFLAREAPI).CreateOptions.RequestedRole, and preserve Route 53's registrar-only region check and conversion observers.DocsURLfrom the lowercase canonical type name. Preserve explicit legacy-path overrides, reject overrides equal to the default during registration, and remove redundant URLs from the pilot definitions. Test defaults, overrides, alias lookups, and rejection independently of later stages.GetZoneRecordsmethod and remove its embedding of NONE, which now implements only the registrar role.This is Stage 2 of the provider API rollout. Stage 1 (#4955) has merged, and this branch includes the current syntax-test compatibility adjustment. Remaining provider migrations, consumer/alias consolidation, and
SupportedTypesvalidation will follow in separate PRs.RecordAuditingProviderremains a temporary migration interface;AuditRecordswill become part ofmodels.DNSProviderat the end of Stage 3.Validation at
fdeac2b3:go test ./...bin/generate-all.sh: formatting, generation, module tidy,go fix ./..., repository-wide golangci-lint (0 issues), and staticcheck all pass; no additional tracked changes.git diff --checkRoute 53 and Cloudflare regression tests use local mocks; no live provider integration tests or DNS mutations were performed.