Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider consumers still depended on compatibility registries after all providers migrated to
providers.Register. This completes Stage 4 by using definitions throughout and sharing provider initialization between both preview/push paths.This PR is stacked on #4965 and targets
tlim_stage3_migrate. Retarget to main after Stage 3 merges.get-zones, and custom-record ownership checks. Preserve legacy missing-TYPE diagnostics and fallbacks.VendorAPIDocURL;initdisplays the resolved DNSControl documentation link and the vendor API documentation link when supplied. URL defaulting and redundant-override validation are provided by Stage 2 (refactor: Stage 2: Adopt new way for providers to register, test with 4 providers #4956); migrated provider overrides are handled in Stage 3 (refactor: Stage 3: Migrate remaining providers to providers.Register #4965).SupportedTypesrollout. Emitted JavaScript syntax remains unchanged for Stage 7.Validation:
go test ./...,bin/generate-all.sh(includinggo fix, golangci-lint with 0 issues, and staticcheck), andgit diff --checkpass. Regression tests cover aliases through both initialization entry points, wizard enumeration and documentation links, CLI parsing, custom records, canonical generator counts, paths stable across type renames, and vendor API documentation metadata. Generated capability documentation, CODEOWNERS, labels, dependencies, and JavaScript fixtures are unchanged. No live integration profile was selected locally.