Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of registering each type a provider supports, with this change the types are reported as a list:
Other capabilities become individual fields.
This data is converted so that legacy code still works. Legacy code will be converted in the future.
An example tells the story better:
CC @cafferata this is the base PR. Converting all the other providers is in #4968
Details...
Providers can now opt into an exhaustive
Definition.SupportedTypesdeclaration.Defaultcontains A, AAAA, CAA, CNAME, MX, NS, SRV, and TXT. For example,[]string{"Default", "NS:Cannot"}excludes NS from that baseline;[]string{"RFC", "CAA:Cannot"}allows ordinary catalog records except CAA;[]string{"*"}also allows pseudo-types. Existing legacy providers keep their previous validation coverage.This implements Stage 5 on top of #4966 and targets
tlim_stage4_registry.Validation passed:
go test ./...;bin/generate-all.sh(including go fix, golangci-lint with 0 issues, and staticcheck);git diff --check. The initial Stage 5 implementation also passedgo test -race -count=2 ./pkg/providers ./pkg/privatetypes ./pkg/normalize ./providers/bind. No live provider integration profile was selected.