Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 of the provider registration redesign. Depends on #4956; this PR targets
tlim_stage2_unifyso the diff contains only Stage 3. Retarget tomainafter Stage 2 merges.Migrate the remaining 70 providers to
providers.Register, with receiver-based initialization and auditing. All 75 providers now have unified definitions. MoveAuditRecordsintomodels.DNSProviderand remove the temporaryRecordAuditingProviderinterface and separate registration check.SupportedTypesrollout.Interface discovery corrects existing capability declarations:
ListZonesand no longer advertise zone listing.EnsureZoneExistsmethods from AZURE_PRIVATE_DNS and MIKROTIK. Azure Private DNS no longer advertises creation; MikroTik retains its false capability.Validation:
go test ./...,bin/generate-all.sh(includinggo fix, golangci-lint with 0 issues, and staticcheck), andgit diff --checkpass. New tests cover all-provider registration and credential-free auditing, derived capabilities, account/role/limiter isolation, observer injection, metadata/error propagation, and Hetzner cache callbacks bound to the runtime receiver. A before/after registry comparison confirms unchanged roles, maintainers, TTLs, credential fields, and non-interface-derived feature notes; providers previously lacking credential metadata gain friendly names and derived roles. Documentation URLs follow Stage 2's defaults with explicit legacy overrides. No live provider integration profile was selected.