Align viem calls and env discovery in tests #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 10, 2025
youngkidwarrior
force-pushed
the
test_align_wrapper_viem_calls_and_env_discovery_manager_test_minor_fixes_
branch
from
f81d703 to
bc8cce2
Compare
youngkidwarrior
force-pushed
the
chore_config_ensure_hardfork_cancun_on_hardhat_network
branch
from
f98498d to
7ec99a4
Compare
…ndearnrewards_bubble_erc4626_hooks_factory-gated_join_flow (886f744) Why: Apply the same non-artifacts changes from top-of-stack to this branch: - Rename RewardsAggregator -> SendEarnRewards - Bubble ERC4626 hooks; factory-gated vault routing - Ignition module rename; minimal tests/mocks; docs labels Test plan: - npx hardhat compile - npx hardhat test --grep "SendEarnRewards"
youngkidwarrior
force-pushed
the
test_align_wrapper_viem_calls_and_env_discovery_manager_test_minor_fixes_
branch
from
bc8cce2 to
add9262
Compare
youngkidwarrior
force-pushed
the
chore_config_ensure_hardfork_cancun_on_hardhat_network
branch
from
7ec99a4 to
497858c
Compare
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Reduce flakiness and ensure tests resolve env/config in a
consistent way.
Test plan: