Skip to content

Conversation

@youngkidwarrior
Copy link
Collaborator

Tests: v2 routing, single-vault withdraw, totalAssets view, transfer re-attribution

  • Deposit routes via affiliates(user) and records underlying shares
  • Withdraw resolves to a single vault and reverts when insufficient
  • totalAssets sums convertToAssets across wrapper-held positions in tracked vaults
  • Transfers proportionally re-attribute underlying shares (no external calls)

Test plan:

  • Run: bunx hardhat test test/rewards/SendEarnRewards.erc4626.spec.ts

Revert per-user transfer re-attribution; remove _update override

Why:

  • Transfers no longer re-attribute underlying shares; we will update flows and
    asset mappings only on deposit/withdraw/redeem per the corrected docs
  • Remove per-user active vault tracking used only for re-attribution

Test plan:

  • Compile

Docs: expand CFA v2.1 into professional spec

  • Purpose/scope, definitions, dependencies, state model, invariants, resolution
  • Triggers, placeholder policy, lifecycle flows with precise steps
  • Rounding/safety/observability/failure modes/implementation notes/open items

Test plan:

  • Render docs; verify sections and step details

…re-attribution

- Deposit routes via affiliates(user) and records underlying shares
- Withdraw resolves to a single vault and reverts when insufficient
- totalAssets sums convertToAssets across wrapper-held positions in tracked vaults
- Transfers proportionally re-attribute underlying shares (no external calls)

Test plan:
- Run: bunx hardhat test test/rewards/SendEarnRewards.erc4626.spec.ts
Why:
- Transfers no longer re-attribute underlying shares; we will update flows and
  asset mappings only on deposit/withdraw/redeem per the corrected docs
- Remove per-user active vault tracking used only for re-attribution

Test plan:
- Compile
- Purpose/scope, definitions, dependencies, state model, invariants, resolution
- Triggers, placeholder policy, lifecycle flows with precise steps
- Rounding/safety/observability/failure modes/implementation notes/open items

Test plan:
- Render docs; verify sections and step details
Copy link
Collaborator Author

youngkidwarrior commented Sep 24, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants