Skip to content

Conversation

@youngkidwarrior
Copy link
Collaborator

Why:
Align depositVaultShares with ERC4626 preview semantics by minting
shares using pre-ingestion NAV (snapshot totalAssets/totalSupply) so
previewDeposit matches runtime behavior. Adds domain tests for
SendEarn-wrapper behavior (routing, gating, NAV invariants, and
depositVaultShares reverts). Gates CFA/integration suites until v2.1.

Test plan:

  • npx hardhat test
  • Expect: ERC4626-only suite green; new NAV test passes; CFA/integration
    suites are pending unless RUN_CFA/RUN_INTEGRATION are set.

Copy link
Collaborator Author

youngkidwarrior commented Sep 24, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@youngkidwarrior youngkidwarrior force-pushed the rewards_depositvaultshares_pre-nav_add_tests branch from 0e3452d to 0aa7762 Compare September 24, 2025 16:25
Why:
Align depositVaultShares with ERC4626 preview semantics by minting
shares using pre-ingestion NAV (snapshot totalAssets/totalSupply) so
previewDeposit matches runtime behavior. Adds domain tests for
SendEarn-wrapper behavior (routing, gating, NAV invariants, and
depositVaultShares reverts). Gates CFA/integration suites until v2.1.

Test plan:
- npx hardhat test
- Expect: ERC4626-only suite green; new NAV test passes; CFA/integration
  suites are pending unless RUN_CFA/RUN_INTEGRATION are set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants