Preparation for release v2025.2 (Zonemaster-Engine) #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
requested review from
MichaelTimbert,
marc-vanderwal,
mattias-p,
tgreenx and
tolvmannen
This was referenced Dec 7, 2025
Contributor
marc-vanderwal
left a comment
marc-vanderwal
left a comment
There was a problem hiding this comment.
In hindsight, shouldn’t the new MethodV2 method (see #1475) be V-Minor instead of V-Patch? It is, after all, a “functional [change] that is fully backward compatible”, according to the documentation.
Co-authored-by: Marc van der Wal <[email protected]>
Contributor
Author
Increase version. |
marc-vanderwal
previously approved these changes
Dec 9, 2025
tgreenx
reviewed
Dec 16, 2025
Co-authored-by: tgreenx <[email protected]>
Co-authored-by: tgreenx <[email protected]>
Contributor
Author
|
@tgreenx and @marc-vanderwal, please re-review. |
marc-vanderwal
approved these changes
Dec 16, 2025
tgreenx
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates
Changes,lib/Zonemaster/Engine.pmandMakefile.PLfor the release.CI will fail until zonemaster/zonemaster-ldns#234 has been merged.
How to test this PR
Review.