Implement new MethodV2: Get-Parent-NS-Names-and-IPs #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-vanderwal
requested review from
MichaelTimbert,
matsduf,
mattias-p and
tgreenx
matsduf
requested changes
Oct 29, 2025
Contributor
|
Can the new unit test file format introduced by #1467 be used in this case too? |
Contributor
Author
Alas, no, because MethodsV2 tests do not work quite the same way as test case tests do. I’d need to implement a slightly different DSL if we wanted a format similar to #1467. It would be nice to have that, but it didn’t feel urgent to me because we are much less likely to touch MethodsV2 unit tests than test case tests. |
marc-vanderwal
force-pushed
the
feature/get-parent-ns-names-and-ips
branch
from
5faaa92 to
d6e9c1a
Compare
matsduf
previously approved these changes
Oct 29, 2025
Contributor
matsduf
left a comment
matsduf
left a comment
There was a problem hiding this comment.
Looks fine. Besides reviewing I rely on the scenarios/unit tests having passed.
tgreenx
added
V-Patch
tgreenx
reviewed
Oct 30, 2025
marc-vanderwal
force-pushed
the
feature/get-parent-ns-names-and-ips
branch
from
d6e9c1a to
72cf62b
Compare
matsduf
requested changes
Nov 3, 2025
Contributor
|
Just two small comments on the language. Else this looks good. Since the unit tests pass I see no issues. |
Implement the new method Get-Parent-NS-Names-and-IPs as per the specification. And make sure that it is memoized properly.
Somehow, introducing Get-Parent-NS-Names-and-IPs, then redefining Get-Parent-NS-IPs in terms of Get-Parent-NS-Names-and-IPs, has had side effects on some unit tests that perform tests against live zones: suddenly, they tried to perform queries to a variety of name servers (among which M-root). I haven’t fully investigated the reason why the tests failed, but it might be because the order of the servers being queried has changed. I also suspect some of the name servers have changed IP addresses since recording. The offending .t files are t/Test.t, t/Test-dnssec.t and t/Test-connectivity.t. Rerecording the corresponding data files is enough to fix everything, except for t/Test-dnssec.data where it was necessary to splice part of the newly recorded data into the existing data so that everything continues to work. It is rather inelegant, but it gets the job done until the affected tests are migrated to the new scenario-based framework.
marc-vanderwal
force-pushed
the
feature/get-parent-ns-names-and-ips
branch
from
72cf62b to
e24a21e
Compare
Contributor
Author
matsduf
approved these changes
Nov 3, 2025
tgreenx
approved these changes
Nov 4, 2025
tolvmannen
added
the
S-ReleaseTested
matsduf
removed
the
V-Patch
matsduf
added
the
V-Minor
Contributor
|
Tag change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR provides an implementation of Get-Parent-NS-Names-and-IPs.
Context
See zonemaster/zonemaster#1418.
Changes
t/*.datafiles where needed.How to test this PR
Unit tests should pass.