Skip to content

Conversation

@huguei
Copy link
Collaborator

@huguei huguei commented May 24, 2023

Purpose

This PR updates spanish translation to keep in sync with develop branch.
It's a successor of PR #1230 that was abandoned.

Please note poedit tool reorder the messages so it appears more changes than effective.

Context

Fixes #1227

Changes

share/es.po

@matsduf matsduf added A-Translation Area: Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version. labels May 24, 2023
@matsduf matsduf added this to the v2023.1 milestone May 24, 2023
@matsduf matsduf requested review from a user and matsduf May 25, 2023 14:30
@matsduf
Copy link
Contributor

matsduf commented May 25, 2023

@huguei, there is some editorial issue that the unit test complains about. I have pushed an update that I hope will resolve it.

@matsduf matsduf mentioned this pull request May 26, 2023
@matsduf
Copy link
Contributor

matsduf commented May 29, 2023

@huguei, is this PR fine to merge?

@huguei
Copy link
Collaborator Author

huguei commented May 29, 2023

@huguei, is this PR fine to merge?

Yes, looks fine including the last editorial update.

Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Spanish, otherwise it looks fine.

@matsduf matsduf merged commit 3d22b71 into zonemaster:develop May 30, 2023
@huguei huguei deleted the translation-update branch May 30, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Translation Area: Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants