-
Notifications
You must be signed in to change notification settings - Fork 36
Fix po-files.t test #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix po-files.t test #1233
Conversation
t/po-files.t
Outdated
|
|
||
| subtest "check msg args" => sub { | ||
| my ( $output, $_ ) = make "check-msg-args"; | ||
| my ( $output, $status ) = make "check-msg-args"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If $status is not used, then I think the following will work as well without defining something not used and that can confuse:
my ( $output ) = make "check-msg-args";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Will this resolve the CI problem in #1234? The error says "tidy po files" is SKIPP'ed: |
|
The issue in #1234 was a different issue. |
Purpose
Fix unit test on Ubuntu 22.04.
Context
The
po-files.ttest fails on Ubuntu 22.04 with messageChanges
How to test this PR
Running the test on Ubuntu 22.04 should succeed.