Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German localization #87

Merged
merged 5 commits into from
Nov 26, 2021
Merged

German localization #87

merged 5 commits into from
Nov 26, 2021

Conversation

vghfr
Copy link

@vghfr vghfr commented Nov 25, 2021

localization speedrun

@zer0Kerbal zer0Kerbal changed the base branch from master to 1.1.3.0-release November 25, 2021 09:30
@zer0Kerbal zer0Kerbal self-requested a review November 25, 2021 09:30
@zer0Kerbal zer0Kerbal self-assigned this Nov 25, 2021
@zer0Kerbal zer0Kerbal added this to the German (Deutsch) <de.cfg> milestone Nov 25, 2021
@zer0Kerbal
Update Readme.md
281bce7 
- remove extraneous bracket `[`
@zer0Kerbal
Copy link
Owner

am hesitant to include any changes to .csproj - bad taste in my mouth last time (not you) did.

@vghfr
Copy link
Author

vghfr commented Nov 26, 2021

ohno what did you do last time?

@zer0Kerbal
Copy link
Owner

@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Nov 26, 2021 •
edited
Loading

ohno what did you do last time?

somebody pushed changes to my repo - which changed the .csproj and .sln - and it cause a massive mess. Fortunately I make backup copies now. chuckle I didn't see the files in time.

Any way for you to remove the .csproj and readme.md changes? I normally do that - and most is already there on this branch.

@zer0Kerbal zer0Kerbal marked this pull request as draft November 26, 2021 07:35
@zer0Kerbal zer0Kerbal marked this pull request as ready for review November 26, 2021 07:37
@vghfr
Copy link
Author

vghfr commented Nov 26, 2021

Yeah, I'll see what I can do

@vghfr
Copy link
Author

vghfr commented Nov 26, 2021

Either I'm just unskilled, or I can't revert those changes...

@zer0Kerbal
Copy link
Owner

I'm being nitpicky -

Either I'm just unskilled, or I can't revert those changes...

all good then. 🥇

@vghfr
Copy link
Author

vghfr commented Nov 26, 2021

I can just replace it if the stuff in release branch is valid

zer0Kerbal added a commit that referenced this pull request Nov 26, 2021
@zer0Kerbal
Add German translation 📢
37a53de 
- closes #71
- closes #87
- updates #55
- than you to @staticalliam7
@zer0Kerbal zer0Kerbal merged commit 301ce04 into zer0Kerbal:1.1.3.0-release Nov 26, 2021
@zer0Kerbal
Copy link
Owner

was able to fix it (I believe) knocking on 🌲

@zer0Kerbal zer0Kerbal added the type: localization related to localization and translations label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zer0Kerbal zer0Kerbal zer0Kerbal approved these changes

Assignees

@zer0Kerbal zer0Kerbal

Labels
type: localization related to localization and translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vghfr @zer0Kerbal