Skip to content

Optional admins for staking configs collection #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optional admins for staking configs collection #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/deploy/campaign/staking-system-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import { getStaking721DeployConfig } from "../missions/staking-erc721/staking721


export const getStaking20SystemConfig = async (
deployAdmin : HardhatEthersSigner,
votingAdmin : HardhatEthersSigner,
stakingAdmin : HardhatEthersSigner,
deployAdmin ?: HardhatEthersSigner,
Copy link
Collaborator

@Whytecrowe Whytecrowe Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is deployAdmin optional?

Copy link
Collaborator Author

@MichaelKorchagin MichaelKorchagin Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because #getBaseZModulesConfig can get him itself as first passed signer.

stakingAdmin ?: HardhatEthersSigner,
) => {
const baseConfig = await getBaseZModulesConfig({ deployAdmin });

Expand All @@ -21,9 +21,9 @@ export const getStaking20SystemConfig = async (
};

export const getStaking721SystemConfig = async (
deployAdmin : HardhatEthersSigner,
votingAdmin : HardhatEthersSigner,
stakingAdmin : HardhatEthersSigner,
deployAdmin ?: HardhatEthersSigner,
stakingAdmin ?: HardhatEthersSigner,
) => {
const baseConfig = await getBaseZModulesConfig({ deployAdmin });

Expand Down