Optional admins for staking configs collection #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 9 9
Lines 510 510
Branches 120 120
=======================================
Hits 497 497
Misses 13 13 🚀 New features to boost your workflow:
|
Whytecrowe
reviewed
Mar 14, 2025
| deployAdmin : HardhatEthersSigner, | ||
| votingAdmin : HardhatEthersSigner, | ||
| stakingAdmin : HardhatEthersSigner, | ||
| deployAdmin ?: HardhatEthersSigner, |
Collaborator
There was a problem hiding this comment.
why is deployAdmin optional?
Collaborator
Author
There was a problem hiding this comment.
Because #getBaseZModulesConfig can get him itself as first passed signer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.