Skip to content

Conversation

@fabiobaltieri
Copy link
Member

@fabiobaltieri fabiobaltieri commented Dec 9, 2025

Breaks in weekly, example west build -p -b thingy53/nrf5340/cpuapp/ns tests/subsys/debug/assert_custom_header


This test does not build correctly on some modules, namely TFM, just run
it on a few platform, that should be enough to validate that the feature
is working correctly.

Fixes #100733

@zephyrbot zephyrbot added area: Debugging area: Tests Issues related to a particular existing or missing test size: XS A PR changing only a single line of code labels Dec 9, 2025
JarmouniA
JarmouniA previously approved these changes Dec 9, 2025
@dsseng
Copy link
Member

dsseng commented Dec 9, 2025

This only affects nRF platforms (mps2/an521/cpu0/ns and max32657evkit/max32657/ns aren't affected for sure), and this is the culprit:

I have not found patching viable (will require quite some reorganisation of dt header files), but perhaps we should make CONFIG_ASSERT_CUSTOM_HEADER conflict with nRF ns targets, as this might impact users as well.

@dsseng
Copy link
Member

dsseng commented Dec 9, 2025

Or actually, what makes CONFIG_ASSERT_CUSTOM_HEADER be applied to TF-M files? It should only be set for files built from Zephyr sources, no?

@dsseng dsseng requested a review from tomi-font December 9, 2025 22:34
@dsseng dsseng added platform: nRF Nordic nRFx area: TF-M ARM Trusted Firmware-M (TF-M) labels Dec 9, 2025
@nashif
Copy link
Member

nashif commented Dec 9, 2025

see #100733

tomi-font
tomi-font previously approved these changes Dec 10, 2025
This test does not build correctly on some modules, namely TFM, just run
it on a few platform, that should be enough to validate that the feature
is working correctly.

Signed-off-by: Fabio Baltieri <[email protected]>
@fabiobaltieri fabiobaltieri dismissed stale reviews from tomi-font and JarmouniA via cb43b91 December 10, 2025 16:34
@fabiobaltieri fabiobaltieri changed the title tests: assert_custom_header: skip when building with TFM tests: assert_custom_header: only build on some platforms Dec 10, 2025
@fabiobaltieri
Copy link
Member Author

Reworked to add a platform_allow list instead

@zephyrbot zephyrbot removed the size: XS A PR changing only a single line of code label Dec 10, 2025
@sonarqubecloud
Copy link

@nashif nashif merged commit 006a951 into zephyrproject-rtos:main Dec 11, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Debugging area: Tests Issues related to a particular existing or missing test area: TF-M ARM Trusted Firmware-M (TF-M) platform: nRF Nordic nRFx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/subsys/debug/assert_custom_header fails in multiple platforms

6 participants