drivers: display: features for ILI9341 driver #99267

NickIOT72 · 2025-11-12T16:01:08Z

Overview

This PR adds some features on zephyr/driver/display files related with ili9xxx header

Features Implemented

modification on display_ili9xxx.c and display_ili9xxx.h files
add condition to select BGR/RGB color order depending on pixel format
change CMD_SET for ILI9341

Files Modified/Added

zephyr/drivers/display/display_ili9xxx.c - changes made on MADCTL register

zephyr/drivers/display/display_ili9xxx.h - Comment modified

zephyr/dts/bindings/display/ilitek,ili9xxx-common.yaml - Added BGR565 value on enum

zephyr/include/zephyr/dt-bindings/display/ili9xxx.h - added ILI9XXX_PIXEL_FORMAT_BGR565 on pixel format

Fixes #99134

dts/bindings/display/ilitek,ili9xxx-common.yaml

drivers/display/display_ili9xxx.c

danieldegrasse · 2025-11-13T01:29:27Z

drivers/display/display_ili9xxx.h

 enum madctl_cmd_set {
 	CMD_SET_1,	/* Default for most of ILI9xxx display controllers */
-	CMD_SET_2,	/* Used by ILI9342c */
+	CMD_SET_2,	/* Used by ILI9342c & ILI9341 */


Have you verified that display orientation works with this change? Assuming that is why it was made

Using CMD_SET_2 the display orientation works as described on the documentation . To verify it, I set a small delay between the squares rendering, comment the display_blanking_off and put it at the beginning. It was shown how each square was appearing according with the order set up on the script, showing the behaviour described on the document: clockwise, from TOP_LEFT(RED) to BOTTOM_LEFT(GRAY SCALE). I used RGB888 for the example

Maybe we should add the delay between the squares in the sample, seems useful.

Should we do that on this PR? or is better left it for another PR?

Should we do that on this PR? or is better left it for another PR?

Out-of-scope for this one

drivers/display/display_ili9xxx.c

addressed. CI failures to be fixed.

NickIOT72 · 2025-11-28T17:27:17Z

@JarmouniA All checks have passed

JarmouniA · 2025-11-28T18:25:53Z

boards/m5stack/m5stack_fire/m5stack_fire_procpu.dts

 			mipi-max-frequency = <30000000>;
 			reg = <0>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <0x20>;


Why not use the macros PANEL_PIXEL_FORMAT_...?

When I used the macro, all the of the boards with this macro didn't compile, that was causing the CI failures. All of these files had the panel.h header but the macro wasn't recognized. That's why I used the hardcoded hex value

All of these files had the panel.h header but the macro wasn't recognized.

That's strange. Push a commit on top with the macros and I will have a look at the errors in CI.

The errors in Twister Build 2 are unrelated to the PR https://github.com/zephyrproject-rtos/zephyr/actions/runs/19791231302/job/56721806874?pr=99267

arch.arm.interrupt.no_optimizations on bl5340_dvk/nrf5340/cpuapp error (Build failure - collect2: error: ld returned 1 exit status) INFO - 2) arch.arm.swap.common.fpu_sharing.no_optimizations on bl5340_dvk/nrf5340/cpuapp error (Build failure - collect2: error: ld returned 1 exit status) INFO - 3) arch.arm.swap.common.no_optimizations on bl5340_dvk/nrf5340/cpuapp error (Build failure - collect2: error: ld returned 1 exit status) INFO - 4) arch.arm.interrupt.no_optimizations on bl5340_dvk/nrf5340/cpunet error (Build failure - collect2: error: ld returned 1 exit status)

The same for Build 3 https://github.com/zephyrproject-rtos/zephyr/actions/runs/19791231302/job/56721806879?pr=99267

arch.arm.swap.common.no_optimizations on bl5340_dvk/nrf5340/cpunet error (Build failure - collect2: error: ld returned 1 exit status)

The way forward is to check if there are already open issues regarding these failures, and comment on them to notify the people involved that the issues are CI Blocker so they get prioritized.
Otherwise create new bug issues for each test failure and I will mark them as CI blockers.

ILI9341 is not deploying correctly the display sample. The screen looks mirrored vertically and the color doesn't match with the sequence expected. To fix it, change the Memory Access Control configuration data. Signed-off-by: Nicolas Moreno <[email protected]>

Replaced display-controller.yaml with lcd-controller.yaml Deleted pixel format property, replacing it with the property on lcd-controller.yaml. Replace ILI9XXX RGB macro with PANEL RGB macro. Also, added condition to verify pixel format is RGB565, BRG565 or RGB888, otherwise it will show error Replaced <zephyr/dt-bindings/display/ili9xxx.h> with <zephyr/dt-bindings/display/panel.h> and ILI9XXX_PIXEL with PANEL_PIXEL in some Devicetrees and files that contained both elements. Fixed some script sintax. Deleted drivers/display/display_ili9xxx.c Signed-off-by: Nicolas Moreno <[email protected]>

Added documentation for doc/releases/migration-guide-4.4.rst in reference with the changes on ili9xxx and ili9341 controllers Signed-off-by: Nicolas Moreno <[email protected]>

NickIOT72 · 2025-12-12T15:34:51Z

I'm currently having issues locally trying to compile

west build -p -b bl5340_dvk/nrf5340/cpuapp/ns tests/subsys/debug/assert_custom_header -T debug.assert_custom_header
and
west build -p -b m5stack_core2/esp32/appcpu tests/subsys/secure_storage/psa/its -T secure_storage.psa.its.secure_storage.store.settings.64-bit_uids

These are failing on the CI. I pushed the code to see if these issues persists. In that case, Should I add another commit or create another PR to fix them?

sonarqubecloud · 2025-12-12T15:42:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JarmouniA · 2025-12-12T15:44:27Z

I'm currently having issues locally trying to compile

west build -p -b bl5340_dvk/nrf5340/cpuapp/ns tests/subsys/debug/assert_custom_header -T debug.assert_custom_header and west build -p -b m5stack_core2/esp32/appcpu tests/subsys/secure_storage/psa/its -T secure_storage.psa.its.secure_storage.store.settings.64-bit_uids

These are failing on the CI. I pushed the code to see if these issues persists. In that case, Should I add another commit or create another PR to fix them?

See #99267 (comment)

the Assert failure is already addressed in main I believe #100769, and the PSA one as well #100835

NickIOT72 · 2025-12-12T18:11:28Z

@JarmouniA it worked, all checks have passed

JarmouniA

Thanks!

zephyrbot added area: Devicetree Bindings area: Boards/SoCs area: Display labels Nov 12, 2025

zephyrbot requested review from JarmouniA, VynDragon, danieldegrasse and jfischer-no November 12, 2025 16:02

NickIOT72 changed the title ~~drivers: display: issue with configuration on ILI9341~~ drivers: display: features for ILI9341 driver Nov 12, 2025

JarmouniA previously requested changes Nov 12, 2025

View reviewed changes

dts/bindings/display/ilitek,ili9xxx-common.yaml Outdated Show resolved Hide resolved

drivers/display/display_ili9xxx.c Outdated Show resolved Hide resolved

drivers/display/display_ili9xxx.c Outdated Show resolved Hide resolved

JarmouniA self-assigned this Nov 12, 2025

danieldegrasse reviewed Nov 13, 2025

View reviewed changes

NickIOT72 requested review from JarmouniA and danieldegrasse November 14, 2025 01:01

JarmouniA reviewed Nov 14, 2025

View reviewed changes

drivers/display/display_ili9xxx.c Show resolved Hide resolved

NickIOT72 force-pushed the changes_display_ili9xxx_h branch from b56244b to 26a3faf Compare November 14, 2025 17:18

zephyrbot added platform: STM32 ST Micro STM32 area: Shields Shields (add-on boards) area: Tests Issues related to a particular existing or missing test platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond platform: Seeed Studio Seeed Studio platforms labels Nov 14, 2025

NickIOT72 requested a review from JarmouniA November 14, 2025 17:20

zephyrbot requested review from FRASTM, GeorgeCGV, avisconti, blauret, erwango, gautierg-st, ioannis-karachalios, kartben and mathieuchopstm November 14, 2025 17:20

NickIOT72 force-pushed the changes_display_ili9xxx_h branch 2 times, most recently from 57da9df to 4515947 Compare November 26, 2025 00:43

zephyrbot requested a review from rerickson1 November 26, 2025 00:45

NickIOT72 force-pushed the changes_display_ili9xxx_h branch 7 times, most recently from d61b23e to f2934f8 Compare November 26, 2025 22:37

JarmouniA reviewed Nov 28, 2025

View reviewed changes

NickIOT72 force-pushed the changes_display_ili9xxx_h branch from f2934f8 to 7f69175 Compare November 28, 2025 21:14

zephyrbot requested a review from JarmouniA November 28, 2025 21:16

NickIOT72 force-pushed the changes_display_ili9xxx_h branch 3 times, most recently from ff4ccbc to 7c7a41c Compare December 1, 2025 17:58

NickIOT72 force-pushed the changes_display_ili9xxx_h branch from 7c7a41c to b0f5090 Compare December 8, 2025 13:58

NickIOT72 added 3 commits December 12, 2025 10:54

doc: releases: add ili9xxx fixes to 4.4 releases notes & migration guide

293722a

Added documentation for doc/releases/migration-guide-4.4.rst in reference with the changes on ili9xxx and ili9341 controllers Signed-off-by: Nicolas Moreno <[email protected]>

NickIOT72 force-pushed the changes_display_ili9xxx_h branch from b0f5090 to 293722a Compare December 12, 2025 15:30

JarmouniA approved these changes Dec 12, 2025

View reviewed changes

mathieuchopstm removed request for gautierg-st and mathieuchopstm December 15, 2025 11:53

drivers: display: features for ILI9341 driver #99267

Are you sure you want to change the base?

drivers: display: features for ILI9341 driver #99267

Uh oh!

Conversation

NickIOT72 commented Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NickIOT72 commented Nov 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JarmouniA Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NickIOT72 commented Dec 12, 2025

Uh oh!

sonarqubecloud bot commented Dec 12, 2025

Quality Gate passed

Uh oh!

JarmouniA commented Dec 12, 2025

Uh oh!

NickIOT72 commented Dec 12, 2025

Uh oh!

JarmouniA left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JarmouniA Nov 28, 2025 •

edited

Loading