net: latmon: Fix net API use #100758
net: latmon: Fix net API use #100758
Conversation
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
LGTM. One reason why the library code was not noticed to contain POSIX symbols is that tests/net/all/prj.conf is missing enabling LATMON i.e., CONFIG_NET_LATMON=y
While at it, could you add a commit to this PR enabling that?
Done :) |
zephyrbot
added
the
area: Tests
In d45cd67 the mayority of the Zephyr networking code was changed to use the Zephyr native net_/zsock_ prefixed types, but some symbols were forgotten. Let's change them. Without these fixes/changes the code still builds in most cases as we are by now setting CONFIG_NET_NAMESPACE_COMPAT_MODE. But when this is not set, things will fail to build. Signed-off-by: Alberto Escolar Piedras <[email protected]>
This subsystem does not use the POSIX_API, and the sample only used one call to the POSIX API to close a socket instead of using the native networking API. Let's just use the native networking API, so we avoid pulling-in more dependencies. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Also build the latency monitor support code. As a sideeffect, we run out of bits in the kernel objects per thread permissions tracking field. So let's increase it to 6 bytes. Signed-off-by: Alberto Escolar Piedras <[email protected]>
bcec3bd introduced some of the non-native API names back into this module. Let's fix it. Signed-off-by: Alberto Escolar Piedras <[email protected]>
|
The last push was just a rebase + an extra commit with a fix for the issue which was just introduced in main in the openthread integration which also triggered in this PR. |
|
aescolar
added
the
Trivial
|
I labelled the PR trivial so we can skip the few last minutes of the 48h if we want to. Any release engineer can merge it now. |
7 participants
In d45cd67 the mayority of the Zephyr networking code was changed to use the Zephyr native net_/zsock_ prefixed types, but some symbols were missed.
Let's change them.
Without these fixes/changes the code still builds in most cases as we are by now setting CONFIG_NET_NAMESPACE_COMPAT_MODE.
But when this is not set, things will fail to build.
And change the respective sample app to use native networking API directly in the one call it wasn't.