Skip to content

ci: tags: Make sure openthread tag is used on OT changes #100898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rlubos wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: tags: Make sure openthread tag is used on OT changes #100898

rlubos wants to merge 3 commits into from
+10 −3

Conversation

@rlubos
Copy link
Contributor

@rlubos rlubos commented Dec 11, 2025

Use namespaced variants instead.

Note: I have purposedly skipped one symbol to see if CI triggers and catches the issue this time. Will update after getting results.

@rlubos
Copy link
Contributor Author

rlubos commented Dec 11, 2025

CC @Cristib05

pdgendt
pdgendt reviewed Dec 11, 2025
View reviewed changes
@pdgendt
Copy link
Contributor

pdgendt commented Dec 11, 2025

Duplicate: #100758

@rlubos rlubos mentioned this pull request Dec 11, 2025
Open
@aescolar
Copy link
Member

aescolar commented Dec 11, 2025

Note: I have purposedly skipped one symbol to see if CI triggers and catches the issue this time

@rlubos it did not :(

@Cristib05
Copy link
Contributor

Cristib05 commented Dec 11, 2025

CC @Cristib05

my bad, sorry for this

@rlubos rlubos force-pushed the net/fix-ot-symbols-in-modules branch from a4f6d45 to fd34b38 Compare December 11, 2025 15:37
@rlubos
MAINTAINERS: Specify OpenThread tests for OpenThread module
9c9b248 
Make sure that OpenThread tests are listed in OpenThread module
area.

Signed-off-by: Robert Lubos <[email protected]>
@rlubos
ci: tags: Add folders covered by openthread tag
090b955 
openthread tag was used in test specifications, but did not define what
source directories were related to this tag.

Signed-off-by: Robert Lubos <[email protected]>
@rlubos
modules: openthread: Breaking change
f632a3d 
Breaking change in OpenThread module to trigger CI failure.

Signed-off-by: Robert Lubos <[email protected]>
@rlubos rlubos force-pushed the net/fix-ot-symbols-in-modules branch from fd34b38 to f632a3d Compare December 11, 2025 16:12
@rlubos rlubos added the DNM This PR should not be merged (Do Not Merge) label Dec 11, 2025
@rlubos
Copy link
Contributor Author

rlubos commented Dec 11, 2025 •
edited
Loading

What I'm trying to achieve here is that changes in modules/openthread trigger twister tests with openthread tag so that we prevent regressions like earlier today.

I'm kind of out of ideas here, where should I specify the directories so that CI runs the twister with openthread tag? What I did so far doesn't seem to work with this PR. @nashif Any help here?

@rlubos rlubos changed the title modules: openthread: Fix overlooked posix symbols ci: tags: Make sure openthread tag is used on OT changes Dec 11, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nashif
Copy link
Member

nashif commented Dec 12, 2025

What I'm trying to achieve here is that changes in modules/openthread trigger twister tests with openthread tag so that we prevent regressions like earlier today.

I'm kind of out of ideas here, where should I specify the directories so that CI runs the twister with openthread tag? What I did so far doesn't seem to work with this PR. @nashif Any help here?

yeah, looking at that. Tags right now only get excluded, not included. This was limited to excluding after we had some issues with coverage at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdgendt pdgendt pdgendt left review comments

@edmont edmont Awaiting requested review from edmont

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@stephanosio stephanosio Awaiting requested review from stephanosio

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

@kartben kartben Awaiting requested review from kartben

At least 2 approving reviews are required to merge this pull request.

Assignees

@nashif nashif

@MaureenHelm MaureenHelm

Labels

area: Continuous Integration area: MAINTAINER File area: OpenThread DNM This PR should not be merged (Do Not Merge)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rlubos @pdgendt @aescolar @Cristib05 @nashif @MaureenHelm @zephyrbot