Align CLI allowed root authority - #311
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webcodex project registerskip stale/unusableallowed_rootscandidates instead of letting one unrelated root poison the whole authority setwebcodex-runner-configand reuse it from Runner project path validationallow_cwd_anywhere, and Windows path fencesIndependent review
Reviewed the exact target range
1924286b02bb9c497a16b75414969f5c3f8ba5e9..a1a6891098c3fa0387eee2ce6e5e94c9df0f72e9. No correctness or authority blocker found.The local worktree had a later unrelated commit (
6369cdc6 Stabilize tunnel startup diagnostics) on top. It is intentionally excluded from this PR; the remote PR branch points exactly ata1a6891098c3fa0387eee2ce6e5e94c9df0f72e9.Validation
cargo test -p webcodex-cli webcodex_cli::project::tests— 15 passed, 0 failedcargo test -p webcodex-runner project_policy— 7 passed, 0 failedcargo check --all-targets -p webcodex-cli— passedcargo fmt --all -- --check— passedgit diff --check 1924286b...a1a68910— passed