Add first-class Runner config control - #314
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runner_config_checkand fencedrunner_config_reloadagainst each exact Runner process's startup-bound config path.ReloadableRunnerConfig/ Unix SIGHUP path.runner_config_controlcapability, with fail-closed old-Runner behavior.not_startedvsoutcome_unknown) and report restart-required startup-only fields explicitly.runner:manageauthority and document the edit → check → reload → runtime_status workflow; reload never writes config files.Review and latest-main integration
Fresh review had already found no architectural blocker. This branch was then rebased onto current
mainincluding #311, #312 and #313.#313 added the independent
structured_cargo_test_execution_policyRunner capability, while this branch addsrunner_config_control. That exposed one concrete integration bug:ALL_RUNNER_FEATUREScontained 55 entries while its fixed array cardinality still declared 54. Reviewer follow-up commit6a468563updates the exact cardinality to 55. No other semantic conflict was found.Fresh validation after rebase/fix
cargo check --all-targets -p webcodex-runner: passed; only the existingdetached_job.rs::state_path_for_jobdead-code warningcargo check --all-targets -p webcodex: passed, 0 errors / 0 warningscargo fmt --all -- --check: passedgit diff --checkand staged diff check: passedA full
cargo test -p webcodex-runner-registryalso exited 0 with242 passed / 0 failed, but the newly merged #313 strict test-count evidence correctly marked the tool-level count assertion unproven because its bounded stdout projection was truncated. The focused 2-test registry proof above is complete and authoritative for this change.No deploy, Runner restart, release, or branch-protection changes.